Commit9219044

authored

fix(coderd/metricscache): avoid logging error for no rows (#12988)

1 parent6b4eb03 commit9219044Copy full SHA for 9219044

File tree

-7

lines changed

-7

lines changed

Lines changed: 6 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -162,6 +162,7 @@ func (c *Cache) refreshDeploymentStats(ctx context.Context) error {`
`162`	`162`	`}`
`163`	`163`
`164`	`164`	`func (c*Cache)run(ctx context.Context,namestring,interval time.Duration,refreshfunc(context.Context)error) {`
	`165`	`+logger:=c.log.With(slog.F("name",name),slog.F("interval",interval))`
`165`	`166`	`ticker:=time.NewTicker(interval)`
`166`	`167`	`deferticker.Stop()`
`167`	`168`
`@@ -173,15 +174,13 @@ func (c *Cache) run(ctx context.Context, name string, interval time.Duration, re`
`173`	`174`	`ifctx.Err()!=nil {`
`174`	`175`	`return`
`175`	`176`	`}`
`176`		`-c.log.Error(ctx,"refresh",slog.Error(err))`
	`177`	`+ifxerrors.Is(err,sql.ErrNoRows) {`
	`178`	`+break`
	`179`	`+}`
	`180`	`+logger.Error(ctx,"refresh metrics failed",slog.Error(err))`
`177`	`181`	`continue`
`178`	`182`	`}`
`179`		`-c.log.Debug(`
`180`		`-ctx,`
`181`		`-name+" metrics refreshed",`
`182`		`-slog.F("took",time.Since(start)),`
`183`		`-slog.F("interval",interval),`
`184`		`-)`
	`183`	`+logger.Debug(ctx,"metrics refreshed",slog.F("took",time.Since(start)))`
`185`	`184`	`break`
`186`	`185`	`}`
`187`	`186`

Comments

(0)