Commit8b3fc67

committed

use atomic add for total bytes value

Signed-off-by: Callum Styan <callumstyan@gmail.com>

1 parent2ebd4ae commit8b3fc67Copy full SHA for 8b3fc67

File tree

+11

-7

lines changed

+11

-7

lines changed

Lines changed: 8 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,10 @@`
`1`	`1`	`package workspacetraffic`
`2`	`2`
`3`		`-import"github.com/prometheus/client_golang/prometheus"`
	`3`	`+import (`
	`4`	`+"sync/atomic"`
	`5`	`+`
	`6`	`+"github.com/prometheus/client_golang/prometheus"`
	`7`	`+)`
`4`	`8`
`5`	`9`	`typeMetricsstruct {`
`6`	`10`	`BytesReadTotal prometheus.CounterVec`
`@@ -75,7 +79,7 @@ type ConnMetrics interface {`
`75`	`79`	`AddError(float64)`
`76`	`80`	`ObserveLatency(float64)`
`77`	`81`	`AddTotal(float64)`
`78`		`-GetTotal()int64`
	`82`	`+GetTotalBytes()int64`
`79`	`83`	`}`
`80`	`84`
`81`	`85`	`typeconnMetricsstruct {`
`@@ -94,10 +98,10 @@ func (c *connMetrics) ObserveLatency(f float64) {`
`94`	`98`	`}`
`95`	`99`
`96`	`100`	`func (c*connMetrics)AddTotal(ffloat64) {`
`97`		`-c.total+=int64(f)`
	`101`	`+atomic.AddInt64(&c.total,int64(f))`
`98`	`102`	`c.addTotal(f)`
`99`	`103`	`}`
`100`	`104`
`101`		`-func (c*connMetrics)GetTotal()int64 {`
	`105`	`+func (c*connMetrics)GetTotalBytes()int64 {`
`102`	`106`	`returnc.total`
`103`	`107`	`}`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -211,8 +211,8 @@ func (r *Runner) Run(ctx context.Context, _ string, logs io.Writer) (err error)`
`211`	`211`	`}`
`212`	`212`
`213`	`213`	`func (r*Runner)GetBytesTransferred() (bytesRead,bytesWrittenint64) {`
`214`		`-bytesRead=r.cfg.ReadMetrics.GetTotal()`
`215`		`-bytesWritten=r.cfg.WriteMetrics.GetTotal()`
	`214`	`+bytesRead=r.cfg.ReadMetrics.GetTotalBytes()`
	`215`	`+bytesWritten=r.cfg.WriteMetrics.GetTotalBytes()`
`216`	`216`	`returnbytesRead,bytesWritten`
`217`	`217`	`}`
`218`	`218`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -423,6 +423,6 @@ func (m *testMetrics) Latencies() []float64 {`
`423`	`423`	`returnm.latencies`
`424`	`424`	`}`
`425`	`425`
`426`		`-func (m*testMetrics)GetTotal()int64 {`
	`426`	`+func (m*testMetrics)GetTotalBytes()int64 {`
`427`	`427`	`returnint64(m.total)`
`428`	`428`	`}`

Comments

(0)