Commit8a9f59a

authored

fix(cli): avoid panic when external auth name isn't provided (#12177)

1 parent4c3d446 commit8a9f59aCopy full SHA for 8a9f59a

File tree

+16

-0

lines changed

+16

-0

lines changed

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -52,6 +52,9 @@ fi`
`52`	`52`	`Command:"coder external-auth access-token slack --extra\"authed_user.id\"",`
`53`	`53`	`},`
`54`	`54`	`),`
	`55`	`+Middleware:clibase.Chain(`
	`56`	`+clibase.RequireNArgs(1),`
	`57`	`+),`
`55`	`58`	`Options: clibase.OptionSet{{`
`56`	`59`	`Name:"Extra",`
`57`	`60`	`Flag:"extra",`

Lines changed: 13 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -46,6 +46,19 @@ func TestExternalAuth(t *testing.T) {`
`46`	`46`	`clitest.Start(t,inv)`
`47`	`47`	`pty.ExpectMatch("bananas")`
`48`	`48`	`})`
	`49`	`+t.Run("NoArgs",func(t*testing.T) {`
	`50`	`+t.Parallel()`
	`51`	`+srv:=httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter,r*http.Request) {`
	`52`	`+httpapi.Write(context.Background(),w,http.StatusOK, agentsdk.ExternalAuthResponse{`
	`53`	`+AccessToken:"bananas",`
	`54`	`+})`
	`55`	`+}))`
	`56`	`+t.Cleanup(srv.Close)`
	`57`	`+url:=srv.URL`
	`58`	`+inv,_:=clitest.New(t,"--agent-url",url,"external-auth","access-token")`
	`59`	`+watier:=clitest.StartWithWaiter(t,inv)`
	`60`	`+watier.RequireContains("wanted 1 args but got 0")`
	`61`	`+})`
`49`	`62`	`t.Run("SuccessWithExtra",func(t*testing.T) {`
`50`	`63`	`t.Parallel()`
`51`	`64`	`srv:=httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter,r*http.Request) {`

Comments

(0)