Commit8a3f7a9

committed

feat(oauth2): remove unique constraint on app names for RFC 7591 compliance

Change-Id: Iae7a1a06546fbc8de541a52e291f8a4510d57e8aSigned-off-by: Thomas Kosiewski <tk@coder.com>

1 parent88f01e4 commit8a3f7a9Copy full SHA for 8a3f7a9

File tree

-10

lines changed

-10

lines changed

Lines changed: 0 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -8971,12 +8971,6 @@ func (q *FakeQuerier) InsertOAuth2ProviderApp(_ context.Context, arg database.In`
`8971`	`8971`	`q.mutex.Lock()`
`8972`	`8972`	`deferq.mutex.Unlock()`
`8973`	`8973`
`8974`		`-for_,app:=rangeq.oauth2ProviderApps {`
`8975`		`-ifapp.Name==arg.Name {`
`8976`		`-return database.OAuth2ProviderApp{},errUniqueConstraint`
`8977`		`-}`
`8978`		`-}`
`8979`		`-`
`8980`	`8974`	`//nolint:gosimple // Go wants database.OAuth2ProviderApp(arg), but we cannot be sure the structs will remain identical.`
`8981`	`8975`	`app:= database.OAuth2ProviderApp{`
`8982`	`8976`	`ID:arg.ID,`

Lines changed: 0 additions & 3 deletions

Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+-- Restore unique constraint on oauth2_provider_apps.name for rollback`
	`2`	`+-- Note: This rollback may fail if duplicate names exist in the database`
	`3`	`+ALTERTABLE oauth2_provider_apps ADDCONSTRAINT oauth2_provider_apps_name_key UNIQUE (name);`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+-- Remove unique constraint on oauth2_provider_apps.name to comply with RFC 7591`
	`2`	`+-- RFC 7591 does not require unique client names, only unique client IDs`
	`3`	`+ALTERTABLE oauth2_provider_apps DROPCONSTRAINT oauth2_provider_apps_name_key;`

Lines changed: 0 additions & 1 deletion

Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.

Comments

(0)