Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit899836d

Browse files
authored
chore: reduce Windows PG tests flakiness (#16090)
This PR:- Reduces test parallelism on Windows in CI- Unifies wait intervals on Windows with Linux and macOS. Previously wehad custom intervals for Windows to reduce test flakiness on smaller CIworkers, but we don't run tests on small CI workers anymore. Due to howour CI file is defined, forks run tests on small CI machines, but I'mnot sure if the different intervals actually help or whether that's aheuristic that happened to fix issues on a particular day and was itever reevaluated. I propose we make the change and if someone complains,revert it.In particular, reduced test parallelism seems to actually help: I wasable to run Windows tests 5 times in a row without flakes. Not sure ifthat's going to fix the problem long term, but it seems worth trying.
1 parent630fd7c commit899836d

File tree

3 files changed

+4
-27
lines changed

3 files changed

+4
-27
lines changed

‎.github/workflows/ci.yaml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -445,7 +445,10 @@ jobs:
445445
# C: drive is extremely slow: https://github.com/actions/runner-images/issues/8755
446446
mkdir -p "R:/temp/embedded-pg"
447447
go run scripts/embedded-pg/main.go -path "R:/temp/embedded-pg"
448-
DB=ci gotestsum --format standard-quiet -- -v -short -count=1 ./...
448+
# Reduce test parallelism, mirroring what we do for race tests.
449+
# We'd been encountering issues with timing related flakes, and
450+
# this seems to help.
451+
DB=ci gotestsum --format standard-quiet -- -v -short -count=1 -parallel 4 -p 4 ./...
449452
else
450453
go run scripts/embedded-pg/main.go
451454
DB=ci gotestsum --format standard-quiet -- -v -short -count=1 ./...

‎testutil/duration.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
//go:build !windows
2-
31
package testutil
42

53
import (

‎testutil/duration_windows.go

Lines changed: 0 additions & 24 deletions
This file was deleted.

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp