Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit894e6ca

Browse files
fix(coderd): ensure agent WebSocket conn is cleaned up
1 parent8f72538 commit894e6ca

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

‎coderd/workspaceagents.go‎

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -815,10 +815,13 @@ func (api *API) workspaceAgentListeningPorts(rw http.ResponseWriter, r *http.Req
815815
// @Router /workspaceagents/{workspaceagent}/containers/watch [get]
816816
func (api*API)watchWorkspaceAgentContainers(rw http.ResponseWriter,r*http.Request) {
817817
var (
818-
ctx=r.Context()
819818
workspaceAgent=httpmw.WorkspaceAgentParam(r)
819+
logger=api.Logger.Named("agent_container_watcher").With(slog.F("agent_id",workspaceAgent.ID))
820820
)
821821

822+
ctx,cancelCtx:=context.WithCancel(r.Context())
823+
defercancelCtx()
824+
822825
// If the agent is unreachable, the request will hang. Assume that if we
823826
// don't get a response after 30s that the agent is unreachable.
824827
dialCtx,cancel:=context.WithTimeout(ctx,30*time.Second)
@@ -857,8 +860,7 @@ func (api *API) watchWorkspaceAgentContainers(rw http.ResponseWriter, r *http.Re
857860
}
858861
deferrelease()
859862

860-
watcherLogger:=api.Logger.Named("agent_container_watcher").With(slog.F("agent_id",workspaceAgent.ID))
861-
containersCh,closer,err:=agentConn.WatchContainers(ctx,watcherLogger)
863+
containersCh,closer,err:=agentConn.WatchContainers(ctx,logger)
862864
iferr!=nil {
863865
httpapi.Write(ctx,rw,http.StatusInternalServerError, codersdk.Response{
864866
Message:"Internal error watching agent's containers.",
@@ -881,11 +883,11 @@ func (api *API) watchWorkspaceAgentContainers(rw http.ResponseWriter, r *http.Re
881883
// close frames.
882884
_=conn.CloseRead(context.Background())
883885

886+
gohttpapi.HeartbeatClose(ctx,logger,cancelCtx,conn)
887+
884888
ctx,wsNetConn:=codersdk.WebsocketNetConn(ctx,conn,websocket.MessageText)
885889
deferwsNetConn.Close()
886890

887-
gohttpapi.Heartbeat(ctx,conn)
888-
889891
encoder:=json.NewEncoder(wsNetConn)
890892

891893
for {

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp