NotificationsYou must be signed in to change notification settings
Fork914
Star10.1k

Commit88f0131

authored

fix: use dbtime in dbmem query to fix flake (#16773)

Closescoder/internal#447.The test was failing 30% of the time on Windows without the roundingapplied by `dbtime`. `dbtime` was used on the timestamps inserted intothe DB, but not within the query. Once using `dbtime` within the querythere were no failures in 200 runs.

1 parent0f4f6bd commit88f0131Copy full SHA for 88f0131

File tree

1 file changed

-1

lines changed

coderd/database/dbmem
- dbmem.go

1 file changed

-1

lines changed

`‎coderd/database/dbmem/dbmem.go`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -7014,7 +7014,7 @@ func (q *FakeQuerier) GetWorkspaceAgentUsageStatsAndLabels(_ context.Context, cr`
`7014`	`7014`	`}`
`7015`	`7015`	`// WHERE usage = true AND created_at > now() - '1 minute'::interval`
`7016`	`7016`	`// GROUP BY user_id, agent_id, workspace_id`
`7017`		`-ifagentStat.Usage&&agentStat.CreatedAt.After(time.Now().Add(-time.Minute)) {`
	`7017`	`+ifagentStat.Usage&&agentStat.CreatedAt.After(dbtime.Now().Add(-time.Minute)) {`
`7018`	`7018`	`val,ok:=latestAgentStats[key]`
`7019`	`7019`	`if!ok {`
`7020`	`7020`	`latestAgentStats[key]=agentStat`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit88f0131

File tree

1 file changed

1 file changed

`‎coderd/database/dbmem/dbmem.go`

0 commit comments