Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit888c97e

Browse files
committed
Apply review suggestions
1 parent8fd1729 commit888c97e

File tree

2 files changed

+6
-17
lines changed

2 files changed

+6
-17
lines changed

‎enterprise/cli/externalworkspaces.go‎

Lines changed: 5 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -47,23 +47,11 @@ func (r *RootCmd) externalWorkspaces() *serpent.Command {
4747
func (r*RootCmd)externalWorkspaceCreate()*serpent.Command {
4848
opts:= agpl.CreateOptions{
4949
BeforeCreate:func(ctx context.Context,client*codersdk.Client,_ codersdk.Template,templateVersionID uuid.UUID)error {
50-
resources,err:=client.TemplateVersionResources(ctx,templateVersionID)
50+
version,err:=client.TemplateVersion(ctx,templateVersionID)
5151
iferr!=nil {
52-
returnxerrors.Errorf("get template version resources: %w",err)
52+
returnxerrors.Errorf("get template version: %w",err)
5353
}
54-
iflen(resources)==0 {
55-
returnxerrors.Errorf("no resources found for template version %q",templateVersionID)
56-
}
57-
58-
varhasExternalAgentbool
59-
for_,resource:=rangeresources {
60-
ifresource.Type=="coder_external_agent" {
61-
hasExternalAgent=true
62-
break
63-
}
64-
}
65-
66-
if!hasExternalAgent {
54+
if!version.HasExternalAgent {
6755
returnxerrors.Errorf("template version %q does not have an external agent. Only templates with external agents can be used for external workspace creation",templateVersionID)
6856
}
6957

@@ -190,9 +178,9 @@ func (r *RootCmd) externalWorkspaceList() *serpent.Command {
190178
baseFilter:=filter.Filter()
191179

192180
ifbaseFilter.FilterQuery=="" {
193-
baseFilter.FilterQuery="has-external-agent:true"
181+
baseFilter.FilterQuery="has_external_agent:true"
194182
}else {
195-
baseFilter.FilterQuery+="has-external-agent:true"
183+
baseFilter.FilterQuery+="has_external_agent:true"
196184
}
197185

198186
res,err:=agpl.QueryConvertWorkspaces(inv.Context(),client,baseFilter,agpl.WorkspaceListRowFromWorkspace)

‎enterprise/cli/externalworkspaces_test.go‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ func completeWithExternalAgent() *echo.Responses {
4141
},
4242
},
4343
},
44+
HasExternalAgents:true,
4445
},
4546
},
4647
},

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp