Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit88851d2

Browse files
authored
feat: add tracing and prometheus options to exp scaletest dynamic-parameters (#20354)
Adds prometheus server and tracing to `coder exp scaletest dynamic-parameters`part ofcoder/internal#912
1 parenta13f29f commit88851d2

File tree

1 file changed

+58
-6
lines changed

1 file changed

+58
-6
lines changed

‎cli/exp_scaletest_dynamicparameters.go‎

Lines changed: 58 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,25 +4,33 @@ package cli
44

55
import (
66
"fmt"
7+
"net/http"
8+
"time"
79

810
"github.com/prometheus/client_golang/prometheus"
11+
"github.com/prometheus/client_golang/prometheus/promhttp"
912
"golang.org/x/xerrors"
1013

1114
"cdr.dev/slog"
1215
"cdr.dev/slog/sloggers/sloghuman"
16+
"github.com/coder/serpent"
1317

18+
"github.com/coder/coder/v2/codersdk"
1419
"github.com/coder/coder/v2/scaletest/dynamicparameters"
1520
"github.com/coder/coder/v2/scaletest/harness"
16-
"github.com/coder/serpent"
1721
)
1822

1923
const (
2024
dynamicParametersTestName="dynamic-parameters"
2125
)
2226

2327
func (r*RootCmd)scaletestDynamicParameters()*serpent.Command {
24-
vartemplateNamestring
25-
varnumEvalsint64
28+
var (
29+
templateNamestring
30+
numEvalsint64
31+
tracingFlags=&scaletestTracingFlags{}
32+
prometheusFlags=&scaletestPrometheusFlags{}
33+
)
2634
orgContext:=NewOrganizationContext()
2735
output:=&scaletestOutputFlags{}
2836

@@ -51,15 +59,50 @@ func (r *RootCmd) scaletestDynamicParameters() *serpent.Command {
5159
returnerr
5260
}
5361

62+
_,err=requireAdmin(ctx,client)
63+
iferr!=nil {
64+
returnerr
65+
}
66+
67+
client.HTTPClient=&http.Client{
68+
Transport:&codersdk.HeaderTransport{
69+
Transport:http.DefaultTransport,
70+
Header:map[string][]string{
71+
codersdk.BypassRatelimitHeader: {"true"},
72+
},
73+
},
74+
}
75+
76+
reg:=prometheus.NewRegistry()
77+
metrics:=dynamicparameters.NewMetrics(reg,"concurrent_evaluations")
78+
5479
logger:=slog.Make(sloghuman.Sink(inv.Stdout)).Leveled(slog.LevelDebug)
80+
prometheusSrvClose:=ServeHandler(ctx,logger,promhttp.HandlerFor(reg, promhttp.HandlerOpts{}),prometheusFlags.Address,"prometheus")
81+
deferprometheusSrvClose()
82+
83+
tracerProvider,closeTracing,tracingEnabled,err:=tracingFlags.provider(ctx)
84+
iferr!=nil {
85+
returnxerrors.Errorf("create tracer provider: %w",err)
86+
}
87+
deferfunc() {
88+
// Allow time for traces to flush even if command context is
89+
// canceled. This is a no-op if tracing is not enabled.
90+
_,_=fmt.Fprintln(inv.Stderr,"\nUploading traces...")
91+
iferr:=closeTracing(ctx);err!=nil {
92+
_,_=fmt.Fprintf(inv.Stderr,"\nError uploading traces: %+v\n",err)
93+
}
94+
// Wait for prometheus metrics to be scraped
95+
_,_=fmt.Fprintf(inv.Stderr,"Waiting %s for prometheus metrics to be scraped\n",prometheusFlags.Wait)
96+
<-time.After(prometheusFlags.Wait)
97+
}()
98+
tracer:=tracerProvider.Tracer(scaletestTracerName)
99+
55100
partitions,err:=dynamicparameters.SetupPartitions(ctx,client,org.ID,templateName,numEvals,logger)
56101
iferr!=nil {
57102
returnxerrors.Errorf("setup dynamic parameters partitions: %w",err)
58103
}
59104

60105
th:=harness.NewTestHarness(harness.ConcurrentExecutionStrategy{}, harness.ConcurrentExecutionStrategy{})
61-
reg:=prometheus.NewRegistry()
62-
metrics:=dynamicparameters.NewMetrics(reg,"concurrent_evaluations")
63106

64107
fori,part:=rangepartitions {
65108
forj:=rangepart.ConcurrentEvaluations {
@@ -68,7 +111,14 @@ func (r *RootCmd) scaletestDynamicParameters() *serpent.Command {
68111
Metrics:metrics,
69112
MetricLabelValues: []string{fmt.Sprintf("%d",part.ConcurrentEvaluations)},
70113
}
71-
runner:=dynamicparameters.NewRunner(client,cfg)
114+
varrunner harness.Runnable=dynamicparameters.NewRunner(client,cfg)
115+
iftracingEnabled {
116+
runner=&runnableTraceWrapper{
117+
tracer:tracer,
118+
spanName:fmt.Sprintf("%s/%d/%d",dynamicParametersTestName,i,j),
119+
runner:runner,
120+
}
121+
}
72122
th.AddRun(dynamicParametersTestName,fmt.Sprintf("%d/%d",j,i),runner)
73123
}
74124
}
@@ -106,5 +156,7 @@ func (r *RootCmd) scaletestDynamicParameters() *serpent.Command {
106156
}
107157
orgContext.AttachOptions(cmd)
108158
output.attach(&cmd.Options)
159+
tracingFlags.attach(&cmd.Options)
160+
prometheusFlags.attach(&cmd.Options)
109161
returncmd
110162
}

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp