Commit87c4948

authored

fix: do not block form control rendering for dynamic parameters on parsing error (#18185)

Defer to backend diagnostics when the values cannot be parsed and allowthe form control to render so the user can select a different option.

1 parent2a0a268 commit87c4948Copy full SHA for 87c4948

File tree

-10

lines changed

-10

lines changed

Lines changed: 6 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -387,11 +387,9 @@ const ParameterField: FC<ParameterFieldProps> = ({`
`387`	`387`	`constparsedValues=parseStringArrayValue(value??"");`
`388`	`388`
`389`	`389`	`if(parsedValues.error){`
`390`		`-return(`
`391`		`-<pclassName="text-sm text-content-destructive">`
`392`		`-{parsedValues.error}`
`393`		`-</p>`
`394`		`-);`
	`390`	`+// Diagnostics on parameter already handle this case, do not duplicate error message`
	`391`	`+// Reset user's values to an empty array. This would overwrite any default values`
	`392`	`+parsedValues.values=[];`
`395`	`393`	`}`
`396`	`394`
`397`	`395`	`// Map parameter options to MultiSelectCombobox options format`
`@@ -440,11 +438,9 @@ const ParameterField: FC<ParameterFieldProps> = ({`
`440`	`438`	`constparsedValues=parseStringArrayValue(value??"");`
`441`	`439`
`442`	`440`	`if(parsedValues.error){`
`443`		`-return(`
`444`		`-<pclassName="text-sm text-content-destructive">`
`445`		`-{parsedValues.error}`
`446`		`-</p>`
`447`		`-);`
	`441`	`+// Diagnostics on parameter already handle this case, do not duplicate error message`
	`442`	`+// Reset user's values to an empty array. This would overwrite any default values`
	`443`	`+parsedValues.values=[];`
`448`	`444`	`}`
`449`	`445`
`450`	`446`	`return(`

Comments

(0)