Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit876ee58

Browse files
committed
fix tests
1 parentf7bc2ec commit876ee58

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

‎coderd/database/dbauthz/dbauthz.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ var (
228228
rbac.ResourceOrganization.Type: {rbac.ActionCreate},
229229
rbac.ResourceOrganizationMember.Type: {rbac.ActionCreate},
230230
rbac.ResourceOrgRoleAssignment.Type: {rbac.ActionCreate},
231-
rbac.ResourceProvisionerDaemon.Type: {rbac.ActionCreate},
231+
rbac.ResourceProvisionerDaemon.Type: {rbac.ActionCreate,rbac.ActionUpdate},
232232
rbac.ResourceUser.Type: {rbac.ActionCreate,rbac.ActionUpdate,rbac.ActionDelete},
233233
rbac.ResourceUserData.Type: {rbac.ActionCreate,rbac.ActionUpdate},
234234
rbac.ResourceWorkspace.Type: {rbac.ActionUpdate},

‎coderd/provisionerdserver/provisionerdserver.go‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,9 @@ func (s *server) heartbeat() {
233233
case<-tick.C:
234234
hbCtx,hbCancel:=context.WithTimeout(s.lifecycleCtx,s.HeartbeatInterval)
235235
iferr:=s.heartbeatOnce(hbCtx);err!=nil {
236-
s.Logger.Error(hbCtx,"heartbeat failed",slog.Error(err))
236+
if!xerrors.Is(err,context.DeadlineExceeded)&&!xerrors.Is(err,context.Canceled) {
237+
s.Logger.Error(hbCtx,"heartbeat failed",slog.Error(err))
238+
}
237239
}
238240
hbCancel()
239241
tick.Reset(s.HeartbeatInterval)
@@ -252,8 +254,8 @@ func (s *server) heartbeatOnce(ctx context.Context) error {
252254
returnnil
253255
}
254256

255-
//nolint:gocritic //Provisionerd has specific authz rules.
256-
returns.Database.UpdateProvisionerDaemonLastSeenAt(dbauthz.AsProvisionerd(ctx), database.UpdateProvisionerDaemonLastSeenAtParams{
257+
//nolint:gocritic //This is specifically for updating the last seen at timestamp.
258+
returns.Database.UpdateProvisionerDaemonLastSeenAt(dbauthz.AsSystemRestricted(ctx), database.UpdateProvisionerDaemonLastSeenAtParams{
257259
ID:s.ID,
258260
LastSeenAt: sql.NullTime{Time:s.timeNow(),Valid:true},
259261
})

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp