Commit86d19b8

committed

docs: add comment about wonky code

1 parentcb92b79 commit86d19b8Copy full SHA for 86d19b8

File tree

+10

-0

lines changed

+10

-0

lines changed

Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -62,6 +62,16 @@ export const useFilter = ({`
`62`	`62`	`return;`
`63`	`63`	`}`
`64`	`64`
	`65`	`+/**`
	`66`	`+ *@todo 2025-07-15 - We have a slightly nasty bug here, where trying to`
	`67`	`+ * update state the "React way" causes our code to break.`
	`68`	`+ *`
	`69`	`+ * In theory, it would be better to make a copy of the search params. We`
	`70`	`+ * can then mutate and dispatch the copy instead of the original. Doing`
	`71`	`+ * that causes other parts of our existing logic to break, though.`
	`72`	`+ * That's a sign that our other code is slightly broken, and only just`
	`73`	`+ * happens to work by chance right now.`
	`74`	`+ */`
`65`	`75`	`searchParams.set(useFilterParamsKey,serialized);`
`66`	`76`	`onSearchParamsChange(searchParams);`
`67`	`77`	`onUpdate?.(serialized);`

Comments

(0)