Commit854ef5b

authored

fix: improve create workspace page for dynamic parameters (#18139)

- Avoid scrolling on workspace creation- hide auth required badge when authenticated

1 parent19745a2 commit854ef5bCopy full SHA for 854ef5b

File tree

-3

lines changed

-3

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -179,7 +179,7 @@ export const CreateWorkspacePageViewExperimental: FC<`
`179`	`179`	`},[error]);`
`180`	`180`
`181`	`181`	`useEffect(()=>{`
`182`		`-if(form.submitCount>0&&form.errors){`
	`182`	`+if(form.submitCount>0&&Object.keys(form.errors).length>0){`
`183`	`183`	`workspaceNameInputRef.current?.scrollIntoView({`
`184`	`184`	`behavior:"smooth",`
`185`	`185`	`block:"center",`

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -38,8 +38,12 @@ export const ExternalAuthButton: FC<ExternalAuthButtonProps> = ({`
`38`	`38`	`/>`
`39`	`39`	`)}`
`40`	`40`	`<pclassName="font-semibold text-sm m-0">{auth.display_name}</p>`
`41`		`-{!auth.optional&&(`
`42`		`-<Badgesize="sm"variant={error ?"destructive" :"warning"}>`
	`41`	`+{!auth.authenticated&&!auth.optional&&(`
	`42`	`+<Badge`
	`43`	`+size="sm"`
	`44`	`+border="none"`
	`45`	`+variant={error ?"destructive" :"warning"}`
	`46`	`+>`
`43`	`47`	`Required`
`44`	`48`	`</Badge>`
`45`	`49`	`)}`

Comments

(0)