Commit8494aa9

committed

chore: return safe copy of string slice in 'ParseStringSliceClaim'

Claims parsed should be safe to mutate and filter. This was likelynot causing any bugs or issues, and just doing this out of precaution

1 parent5e4050e commit8494aa9Copy full SHA for 8494aa9

File tree

+14

-1

lines changed

+14

-1

lines changed

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -186,7 +186,9 @@ func ParseStringSliceClaim(claim interface{}) ([]string, error) {`
`186`	`186`	`// The simple case is the type is exactly what we expected`
`187`	`187`	`asStringArray,ok:=claim.([]string)`
`188`	`188`	`ifok {`
`189`		`-returnasStringArray,nil`
	`189`	`+cpy:=make([]string,len(asStringArray))`
	`190`	`+copy(cpy,asStringArray)`
	`191`	`+returncpy,nil`
`190`	`192`	`}`
`191`	`193`
`192`	`194`	`asArray,ok:=claim.([]interface{})`

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -136,6 +136,17 @@ func TestParseStringSliceClaim(t *testing.T) {`
`136`	`136`	`}`
`137`	`137`	`}`
`138`	`138`
	`139`	`+funcTestParseStringSliceClaimReference(t*testing.T) {`
	`140`	`+t.Parallel()`
	`141`	`+`
	`142`	`+varvalany= []string{"a","b","c"}`
	`143`	`+parsed,err:=idpsync.ParseStringSliceClaim(val)`
	`144`	`+require.NoError(t,err)`
	`145`	`+`
	`146`	`+parsed[0]=""`
	`147`	`+require.Equal(t,"a",val.([]string)[0],"should not modify original value")`
	`148`	`+}`
	`149`	`+`
`139`	`150`	`funcTestIsHTTPError(t*testing.T) {`
`140`	`151`	`t.Parallel()`
`141`	`152`

Comments

(0)