Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit840afb2

Browse files
feat: select template version for tasks (#20146)
Allows users with `updateTemplates` permission to select a specifictemplate version when creating a task.One of the biggest changes was moving `TaskPrompt` into `modules/task`and adding a Storybook entry for it. I also moved some stories from`TasksPage` to simplify its story.<img width="1208" height="197" alt="Screenshot 2025-10-02 at 12 09 06"src="https://github.com/user-attachments/assets/b85d2723-bb52-442b-b8eb-36721944a653"/>Closes#19986
1 parent3f49e28 commit840afb2

File tree

4 files changed

+386
-280
lines changed

4 files changed

+386
-280
lines changed
Lines changed: 296 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,296 @@
1+
import{
2+
MockAIPromptPresets,
3+
MockNewTaskData,
4+
MockPresets,
5+
MockTask,
6+
MockTasks,
7+
MockTemplate,
8+
MockTemplateVersion,
9+
MockTemplateVersionExternalAuthGithub,
10+
MockTemplateVersionExternalAuthGithubAuthenticated,
11+
MockUserOwner,
12+
mockApiError,
13+
}from"testHelpers/entities";
14+
import{withAuthProvider,withGlobalSnackbar}from"testHelpers/storybook";
15+
importtype{Meta,StoryObj}from"@storybook/react-vite";
16+
import{API}from"api/api";
17+
import{expect,spyOn,userEvent,waitFor,within}from"storybook/test";
18+
importtypeTasksPagefrom"../../../pages/TasksPage/TasksPage";
19+
import{TaskPrompt}from"./TaskPrompt";
20+
21+
constmeta:Meta<typeofTasksPage>={
22+
title:"modules/tasks/TaskPrompt",
23+
component:TaskPrompt,
24+
decorators:[withAuthProvider],
25+
parameters:{
26+
user:MockUserOwner,
27+
permissions:{
28+
updateTemplates:true,
29+
},
30+
},
31+
beforeEach:()=>{
32+
spyOn(API,"getTemplateVersionExternalAuth").mockResolvedValue([]);
33+
spyOn(API,"getTemplates").mockResolvedValue([
34+
MockTemplate,
35+
{
36+
...MockTemplate,
37+
id:"test-template-2",
38+
name:"template 2",
39+
display_name:"Template 2",
40+
},
41+
]);
42+
spyOn(API,"getTemplateVersions").mockResolvedValue([
43+
{
44+
...MockTemplateVersion,
45+
name:"v1.0.0",
46+
},
47+
]);
48+
spyOn(API,"getTemplateVersionPresets").mockResolvedValue(null);
49+
},
50+
args:{
51+
templates:[MockTemplate],
52+
},
53+
};
54+
55+
exportdefaultmeta;
56+
typeStory=StoryObj<typeofTasksPage>;
57+
58+
exportconstLoadingTemplates:Story={
59+
args:{
60+
templates:undefined,
61+
},
62+
};
63+
64+
exportconstEmptyTemplates:Story={
65+
args:{
66+
templates:[],
67+
},
68+
};
69+
70+
exportconstWithPresets:Story={
71+
beforeEach:()=>{
72+
spyOn(API,"getTemplateVersionPresets").mockResolvedValue(MockPresets);
73+
},
74+
};
75+
76+
exportconstReadOnlyPresetPrompt:Story={
77+
beforeEach:()=>{
78+
spyOn(API,"getTemplateVersionPresets").mockResolvedValue(
79+
MockAIPromptPresets,
80+
);
81+
},
82+
};
83+
84+
exportconstOnSuccess:Story={
85+
decorators:[withGlobalSnackbar],
86+
parameters:{
87+
permissions:{
88+
updateTemplates:false,
89+
},
90+
},
91+
beforeEach:()=>{
92+
constactiveVersionId=`${MockTemplate.active_version_id}-latest`;
93+
spyOn(API,"getTemplate").mockResolvedValue({
94+
...MockTemplate,
95+
active_version_id:activeVersionId,
96+
});
97+
spyOn(API.experimental,"createTask").mockResolvedValue(MockTask);
98+
},
99+
play:async({ canvasElement, step})=>{
100+
constcanvas=within(canvasElement);
101+
102+
awaitstep("Run task",async()=>{
103+
constprompt=awaitcanvas.findByLabelText(/prompt/i);
104+
awaituserEvent.type(prompt,MockNewTaskData.prompt);
105+
constsubmitButton=canvas.getByRole("button",{name:/runtask/i});
106+
awaitwaitFor(()=>expect(submitButton).toBeEnabled());
107+
awaituserEvent.click(submitButton);
108+
});
109+
110+
awaitstep("Uses latest template version",()=>{
111+
expect(API.experimental.createTask).toHaveBeenCalledWith(
112+
MockUserOwner.id,
113+
{
114+
input:MockNewTaskData.prompt,
115+
template_version_id:`${MockTemplate.active_version_id}-latest`,
116+
template_version_preset_id:undefined,
117+
},
118+
);
119+
});
120+
121+
awaitstep("Displays success message",async()=>{
122+
constbody=within(canvasElement.ownerDocument.body);
123+
constsuccessMessage=awaitbody.findByText(/taskcreated/i);
124+
expect(successMessage).toBeInTheDocument();
125+
});
126+
},
127+
};
128+
129+
exportconstSelectTemplateVersion:Story={
130+
decorators:[withGlobalSnackbar],
131+
beforeEach:()=>{
132+
spyOn(API,"getTemplateVersions").mockResolvedValue([
133+
{
134+
...MockTemplateVersion,
135+
id:"test-template-version-2",
136+
name:"v2.0.0",
137+
},
138+
{
139+
...MockTemplateVersion,
140+
name:"v1.0.0",
141+
},
142+
]);
143+
spyOn(API.experimental,"createTask").mockResolvedValue(MockTask);
144+
},
145+
play:async({ canvasElement, step})=>{
146+
constcanvas=within(canvasElement);
147+
148+
awaitstep("Fill prompt",async()=>{
149+
constprompt=awaitcanvas.findByLabelText(/prompt/i);
150+
awaituserEvent.type(prompt,MockNewTaskData.prompt);
151+
});
152+
153+
awaitstep("Select version",async()=>{
154+
constbody=within(canvasElement.ownerDocument.body);
155+
constversionSelect=awaitcanvas.findByLabelText(/templateversion/i);
156+
awaituserEvent.click(versionSelect);
157+
constversionOption=awaitbody.findByRole("option",{
158+
name:/v2.0.0/i,
159+
});
160+
awaituserEvent.click(versionOption);
161+
});
162+
163+
awaitstep("Submit form",async()=>{
164+
constsubmitButton=canvas.getByRole("button",{name:/runtask/i});
165+
awaitwaitFor(()=>expect(submitButton).toBeEnabled());
166+
awaituserEvent.click(submitButton);
167+
});
168+
169+
awaitstep("Uses selected version",()=>{
170+
expect(API.experimental.createTask).toHaveBeenCalledWith(
171+
MockUserOwner.id,
172+
{
173+
input:MockNewTaskData.prompt,
174+
template_version_id:"test-template-version-2",
175+
template_version_preset_id:undefined,
176+
},
177+
);
178+
});
179+
180+
awaitstep("Displays success message",async()=>{
181+
constbody=within(canvasElement.ownerDocument.body);
182+
constsuccessMessage=awaitbody.findByText(/taskcreated/i);
183+
expect(successMessage).toBeInTheDocument();
184+
});
185+
},
186+
};
187+
188+
exportconstOnError:Story={
189+
decorators:[withGlobalSnackbar],
190+
beforeEach:()=>{
191+
spyOn(API,"getTemplates").mockResolvedValue([MockTemplate]);
192+
spyOn(API,"getTemplate").mockResolvedValue(MockTemplate);
193+
spyOn(API.experimental,"getTasks").mockResolvedValue(MockTasks);
194+
spyOn(API.experimental,"createTask").mockRejectedValue(
195+
mockApiError({
196+
message:"Failed to create task",
197+
detail:"You don't have permission to create tasks.",
198+
}),
199+
);
200+
},
201+
play:async({ canvasElement, step})=>{
202+
constcanvas=within(canvasElement);
203+
204+
awaitstep("Run task",async()=>{
205+
constprompt=awaitcanvas.findByLabelText(/prompt/i);
206+
awaituserEvent.type(prompt,"Create a new task");
207+
constsubmitButton=canvas.getByRole("button",{name:/runtask/i});
208+
awaitwaitFor(()=>expect(submitButton).toBeEnabled());
209+
awaituserEvent.click(submitButton);
210+
});
211+
212+
awaitstep("Verify error",async()=>{
213+
awaitcanvas.findByText(/failedtocreatetask/i);
214+
});
215+
},
216+
};
217+
218+
exportconstAuthenticatedExternalAuth:Story={
219+
beforeEach:()=>{
220+
spyOn(API.experimental,"getTasks")
221+
.mockResolvedValueOnce(MockTasks)
222+
.mockResolvedValue([MockNewTaskData, ...MockTasks]);
223+
spyOn(API.experimental,"createTask").mockResolvedValue(MockTask);
224+
spyOn(API,"getTemplateVersionExternalAuth").mockResolvedValue([
225+
MockTemplateVersionExternalAuthGithubAuthenticated,
226+
]);
227+
},
228+
play:async({ canvasElement, step})=>{
229+
constcanvas=within(canvasElement);
230+
231+
awaitstep("Does not render external auth",async()=>{
232+
expect(
233+
canvas.queryByText(/externalauthentication/),
234+
).not.toBeInTheDocument();
235+
});
236+
},
237+
parameters:{
238+
chromatic:{
239+
disableSnapshot:true,
240+
},
241+
},
242+
};
243+
244+
exportconstMissingExternalAuth:Story={
245+
beforeEach:()=>{
246+
spyOn(API.experimental,"getTasks")
247+
.mockResolvedValueOnce(MockTasks)
248+
.mockResolvedValue([MockNewTaskData, ...MockTasks]);
249+
spyOn(API.experimental,"createTask").mockResolvedValue(MockTask);
250+
spyOn(API,"getTemplateVersionExternalAuth").mockResolvedValue([
251+
MockTemplateVersionExternalAuthGithub,
252+
]);
253+
},
254+
play:async({ canvasElement, step})=>{
255+
constcanvas=within(canvasElement);
256+
257+
awaitstep("Submit is disabled",async()=>{
258+
constprompt=awaitcanvas.findByLabelText(/prompt/i);
259+
awaituserEvent.type(prompt,MockNewTaskData.prompt);
260+
constsubmitButton=canvas.getByRole("button",{name:/runtask/i});
261+
expect(submitButton).toBeDisabled();
262+
});
263+
264+
awaitstep("Renders external authentication",async()=>{
265+
awaitcanvas.findByRole("button",{name:/connecttogithub/i});
266+
});
267+
},
268+
};
269+
270+
exportconstExternalAuthError:Story={
271+
beforeEach:()=>{
272+
spyOn(API.experimental,"getTasks")
273+
.mockResolvedValueOnce(MockTasks)
274+
.mockResolvedValue([MockNewTaskData, ...MockTasks]);
275+
spyOn(API.experimental,"createTask").mockResolvedValue(MockTask);
276+
spyOn(API,"getTemplateVersionExternalAuth").mockRejectedValue(
277+
mockApiError({
278+
message:"Failed to load external auth",
279+
}),
280+
);
281+
},
282+
play:async({ canvasElement, step})=>{
283+
constcanvas=within(canvasElement);
284+
285+
awaitstep("Submit is disabled",async()=>{
286+
constprompt=awaitcanvas.findByLabelText(/prompt/i);
287+
awaituserEvent.type(prompt,MockNewTaskData.prompt);
288+
constsubmitButton=canvas.getByRole("button",{name:/runtask/i});
289+
expect(submitButton).toBeDisabled();
290+
});
291+
292+
awaitstep("Renders error",async()=>{
293+
awaitcanvas.findByText(/failedtoloadexternalauth/i);
294+
});
295+
},
296+
};

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp