Commit838fbc1

authored

fix: improve options table reading (#20341)

From@chrifro - text-sm regular for the body text (24px line height)- text-sm bold and white font for the headline**Before:**<img width="1624" height="967" alt="Screenshot 2025-10-16 at 10 08 19"src="https://github.com/user-attachments/assets/b0ef6aef-57b6-43d0-921b-8028c58866f0"/>**After:**<img width="1624" height="967" alt="Screenshot 2025-10-16 at 10 10 27"src="https://github.com/user-attachments/assets/f39526f3-f0cc-4678-83b3-84bf4161b5be"/>

1 parenta833b7a commit838fbc1Copy full SHA for 838fbc1

File tree

-37

lines changed

-37

lines changed

Lines changed: 5 additions & 14 deletions

Original file line number	Diff line number	Diff line change
`@@ -5,26 +5,17 @@ import type { FC, HTMLAttributes, PropsWithChildren } from "react";`
`5`	`5`	`import{MONOSPACE_FONT_FAMILY}from"theme/constants";`
`6`	`6`
`7`	`7`	`exportconstOptionName:FC<PropsWithChildren>=({ children})=>{`
`8`		`-return<spancss={{display:"block"}}>{children}</span>;`
`9`		`-};`
`10`		`-`
`11`		`-exportconstOptionDescription:FC<PropsWithChildren>=({ children})=>{`
`12`		`-consttheme=useTheme();`
`13`		`-`
`14`	`8`	`return(`
`15`		`-<span`
`16`		`-css={{`
`17`		`-display:"block",`
`18`		`-color:theme.palette.text.secondary,`
`19`		`-fontSize:14,`
`20`		`-marginTop:4,`
`21`		`-}}`
`22`		`->`
	`9`	`+<spanclassName="block text-sm font-medium text-content-primary">`
`23`	`10`	`{children}`
`24`	`11`	`</span>`
`25`	`12`	`);`
`26`	`13`	`};`
`27`	`14`
	`15`	`+exportconstOptionDescription:FC<PropsWithChildren>=({ children})=>{`
	`16`	`+return<spanclassName="text-sm font-normal">{children}</span>;`
	`17`	`+};`
	`18`	`+`
`28`	`19`	`interfaceOptionValueProps{`
`29`	`20`	`children?:boolean\|number\|string\|string[]\|Record<string,boolean>;`
`30`	`21`	`}`

Lines changed: 2 additions & 23 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-import{css}from"@emotion/react";`
`2`	`1`	`importtype{SerpentOption}from"api/typesGenerated";`
`3`	`2`	`import{`
`4`	`3`	`Table,`
`@@ -29,20 +28,7 @@ const OptionsTable: FC<OptionsTableProps> = ({ options, additionalValues }) => {`
`29`	`28`	`}`
`30`	`29`
`31`	`30`	`return(`
`32`		`-<Table`
`33`		`-className="options-table"`
`34`		-css={css`
`35`		`-&td {`
`36`		`-padding-top:24px;`
`37`		`-padding-bottom:24px;`
`38`		`- }`
`39`		`-`
`40`		`-&td:last-child,`
`41`		`-&th:last-child {`
`42`		`-padding-left:32px;`
`43`		`- }`
`44`		- `}
`45`		`->`
	`31`	`+<TableclassName="options-table">`
`46`	`32`	`<TableHeader>`
`47`	`33`	`<TableRow>`
`48`	`34`	`<TableHeadclassName="w-1/2">Option</TableHead>`
`@@ -56,14 +42,7 @@ const OptionsTable: FC<OptionsTableProps> = ({ options, additionalValues }) => {`
`56`	`42`	`<TableCell>`
`57`	`43`	`<OptionName>{option.name}</OptionName>`
`58`	`44`	`<OptionDescription>{option.description}</OptionDescription>`
`59`		`-<div`
`60`		`-css={{`
`61`		`-marginTop:24,`
`62`		`-display:"flex",`
`63`		`-flexWrap:"wrap",`
`64`		`-gap:8,`
`65`		`-}}`
`66`		`->`
	`45`	`+<divclassName="pt-2 flex flex-wrap gap-2">`
`67`	`46`	`{option.flag&&(`
`68`	`47`	`<OptionConfigisSource={option.value_source==="flag"}>`
`69`	`48`	`<OptionConfigFlag>CLI</OptionConfigFlag>`

Comments

(0)