Commit8207094

authored

chore(provisionerd): close completeChan exactly once (#16011)

1 parent9c62547 commit8207094Copy full SHA for 8207094

File tree

-1

lines changed

-1

lines changed

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -70,8 +70,11 @@ func TestProvisionerd(t *testing.T) {`
`70`	`70`	`close(done)`
`71`	`71`	`})`
`72`	`72`	`completeChan:=make(chanstruct{})`
	`73`	`+varcompleted sync.Once`
`73`	`74`	`closer:=createProvisionerd(t,func(ctx context.Context) (proto.DRPCProvisionerDaemonClient,error) {`
`74`		`-deferclose(completeChan)`
	`75`	`+completed.Do(func() {`
	`76`	`+deferclose(completeChan)`
	`77`	`+})`
`75`	`78`	`returnnil,xerrors.New("an error")`
`76`	`79`	`}, provisionerd.LocalProvisioners{})`
`77`	`80`	`require.Condition(t,closedWithin(completeChan,testutil.WaitShort))`

Comments

(0)