Commit80c89fe

committed

refactor: CR's fixes

1 parent3100e01 commit80c89feCopy full SHA for 80c89fe

File tree

-5

lines changed

-5

lines changed

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -286,5 +286,9 @@ func (mc *MetricsCollector) trackHardLimitedStatus(orgName, templateName, preset`
`286`	`286`
`287`	`287`	`key:=hardLimitedPresetKey{orgName:orgName,templateName:templateName,presetName:presetName}`
`288`	`288`
`289`		`-mc.isPresetHardLimited[key]=isHardLimited`
	`289`	`+ifisHardLimited {`
	`290`	`+mc.isPresetHardLimited[key]=true`
	`291`	`+}else {`
	`292`	`+delete(mc.isPresetHardLimited,key)`
	`293`	`+}`
`290`	`294`	`}`

Lines changed: 2 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -1036,17 +1036,15 @@ func TestHardLimitedPresetShouldNotBlockDeletion(t *testing.T) {`
`1036`	`1036`	`require.Equal(t,database.WorkspaceTransitionDelete,workspaceBuilds[0].Transition)`
`1037`	`1037`	`require.Equal(t,database.WorkspaceTransitionStart,workspaceBuilds[1].Transition)`
`1038`	`1038`
`1039`		`-// Metric isreset to zero after preset became outdated.`
	`1039`	`+// Metric isdeleted after preset became outdated.`
`1040`	`1040`	`mf,err=registry.Gather()`
`1041`	`1041`	`require.NoError(t,err)`
`1042`	`1042`	`metric=findMetric(mf,prebuilds.MetricPresetHardLimitedGauge,map[string]string{`
`1043`	`1043`	`"template_name":template.Name,`
`1044`	`1044`	`"preset_name":preset.Name,`
`1045`	`1045`	`"org_name":org.Name,`
`1046`	`1046`	`})`
`1047`		`-require.NotNil(t,metric)`
`1048`		`-require.NotNil(t,metric.GetGauge())`
`1049`		`-require.EqualValues(t,0,metric.GetGauge().GetValue())`
	`1047`	`+require.Nil(t,metric)`
`1050`	`1048`	`})`
`1051`	`1049`	`}`
`1052`	`1050`	`}`

Comments

(0)