Commit7dbfc2b

committed

Apply suggestions from code review

1 parent58ee327 commit7dbfc2bCopy full SHA for 7dbfc2b

File tree

-4

lines changed

-4

lines changed

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -300,9 +300,7 @@ func TestAgent_Session_EnvironmentVariables(t *testing.T) {`
`300`	`300`	`},`
`301`	`301`	`}`
`302`	`302`	`banner:= codersdk.ServiceBannerConfig{}`
`303`		`-fs:=afero.NewMemMapFs()`
`304`	`303`	`session:=setupSSHSession(t,manifest,banner,nil,func(_agenttest.Client,optsagent.Options) {`
`305`		`-opts.Filesystem=fs`
`306`	`304`	`opts.ScriptDataDir=tmpdir`
`307`	`305`	`opts.EnvironmentVariables["MY_OVERRIDE"]="true"`
`308`	`306`	`})`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -345,7 +345,7 @@ func (r RootCmd) workspaceAgent() clibase.Cmd {`
`345`	`345`	`Flag:"script-data-dir",`
`346`	`346`	`Default:os.TempDir(),`
`347`	`347`	`Description:"Specify the location for storing script data.",`
`348`		`-Env:"CODER_AGENT_SCRIPT_DIR",`
	`348`	`+Env:"CODER_AGENT_SCRIPT_DATA_DIR",`
`349`	`349`	`Value:clibase.StringOf(&scriptDataDir),`
`350`	`350`	`},`
`351`	`351`	`{`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ OPTIONS:`
`33`	`33`	`--prometheus-address string, $CODER_AGENT_PROMETHEUS_ADDRESS (default: 127.0.0.1:2112)`
`34`	`34`	`The bind address to serve Prometheus metrics.`
`35`	`35`
`36`		`- --script-data-dir string, $CODER_AGENT_SCRIPT_DIR (default: /tmp)`
	`36`	`+ --script-data-dir string, $CODER_AGENT_SCRIPT_DATA_DIR (default: /tmp)`
`37`	`37`	`Specify the location for storing script data.`
`38`	`38`
`39`	`39`	`--ssh-max-timeout duration, $CODER_AGENT_SSH_MAX_TIMEOUT (default: 72h)`

Comments

(0)