- Notifications
You must be signed in to change notification settings - Fork1k
Commit7d61505
chore: downgrade msw and @radix-ui/dialog (#20098)
The upgrade caused the following error:```node: ../deps/uv/src/unix/stream.c:456: uv__stream_destroy: Assertion `!uv__io_active(&stream->io_watcher, POLLIN | POLLOUT)' failed.```After downgrading `msw`, a new error appeared only in`WorkspacesPage.test.tsx`:```<--- Last few GCs --->[2799:0x292c2000] 16790 ms: Scavenge 336.1 (443.3) -> 322.8 (443.3) MB, pooled: 32 MB, 6.45 / 0.00 ms (average mu = 0.997, current mu = 0.996) allocation failure; [2799:0x292c2000] 16883 ms: Scavenge 336.7 (443.3) -> 326.8 (443.3) MB, pooled: 32 MB, 8.29 / 0.00 ms (average mu = 0.997, current mu = 0.996) allocation failure; [2799:0x292c2000] 16989 ms: Scavenge 339.6 (443.3) -> 329.1 (443.3) MB, pooled: 32 MB, 9.87 / 0.00 ms (average mu = 0.997, current mu = 0.996) allocation failure; ```After some debugging, I traced it to `@radix-ui/dialog`. I didn’t findany open issues about memory leaks there, so my guess is it’s just usingmore memory than our default allocation. Jest has an option to increasethe memory limit, but we should be fine for now.Related issue:[https://github.com/mswjs/msw/issues/2537](https://github.com/mswjs/msw/issues/2537)1 parentaff4398 commit7d61505
2 files changed
+139
-173
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
| 58 | + | |
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
| |||
169 | 169 | | |
170 | 170 | | |
171 | 171 | | |
172 | | - | |
| 172 | + | |
173 | 173 | | |
174 | 174 | | |
175 | 175 | | |
| |||
0 commit comments
Comments
(0)