Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit7d3555e

Browse files
committed
fix some tests
1 parentb7fd329 commit7d3555e

File tree

3 files changed

+2
-16
lines changed

3 files changed

+2
-16
lines changed

‎cli/delete_test.go‎

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import (
1111

1212
"github.com/coder/coder/v2/cli/clitest"
1313
"github.com/coder/coder/v2/coderd/coderdtest"
14-
"github.com/coder/coder/v2/coderd/database"
1514
"github.com/coder/coder/v2/coderd/database/dbauthz"
1615
"github.com/coder/coder/v2/codersdk"
1716
"github.com/coder/coder/v2/pty/ptytest"
@@ -95,10 +94,7 @@ func TestDelete(t *testing.T) {
9594
// this way.
9695
ctx:=testutil.Context(t,testutil.WaitShort)
9796
// nolint:gocritic // Unit test
98-
err:=api.Database.UpdateUserDeletedByID(dbauthz.AsSystemRestricted(ctx), database.UpdateUserDeletedByIDParams{
99-
ID:deleteMeUser.ID,
100-
Deleted:true,
101-
})
97+
err:=api.Database.SoftDeleteUserByID(dbauthz.AsSystemRestricted(ctx),deleteMeUser.ID)
10298
require.NoError(t,err)
10399

104100
inv,root:=clitest.New(t,"delete",fmt.Sprintf("%s/%s",deleteMeUser.ID,workspace.Name),"-y","--orphan")

‎coderd/database/dbauthz/dbauthz_test.go‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1018,13 +1018,6 @@ func (s *MethodTestSuite) TestUser() {
10181018
u:=dbgen.User(s.T(),db, database.User{})
10191019
check.Args(u.ID).Asserts(u,rbac.ActionDelete).Returns()
10201020
}))
1021-
s.Run("UpdateUserDeletedByID",s.Subtest(func(db database.Store,check*expects) {
1022-
u:=dbgen.User(s.T(),db, database.User{Deleted:true})
1023-
check.Args(database.UpdateUserDeletedByIDParams{
1024-
ID:u.ID,
1025-
Deleted:true,
1026-
}).Asserts(u,rbac.ActionDelete).Returns()
1027-
}))
10281021
s.Run("UpdateUserHashedPassword",s.Subtest(func(db database.Store,check*expects) {
10291022
u:=dbgen.User(s.T(),db, database.User{})
10301023
check.Args(database.UpdateUserHashedPasswordParams{

‎coderd/database/dbgen/dbgen.go‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -310,10 +310,7 @@ func User(t testing.TB, db database.Store, orig database.User) database.User {
310310
}
311311

312312
iforig.Deleted {
313-
err=db.UpdateUserDeletedByID(genCtx, database.UpdateUserDeletedByIDParams{
314-
ID:user.ID,
315-
Deleted:orig.Deleted,
316-
})
313+
err=db.SoftDeleteUserByID(genCtx,user.ID)
317314
require.NoError(t,err,"set user as deleted")
318315
}
319316
returnuser

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp