Commit79fd736

authored

chore(site): enable React'sStrictMode (#13399)

1 parent973cc2b commit79fd736Copy full SHA for 79fd736

File tree

+33

-29

lines changed

+33

-29

lines changed

Lines changed: 11 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,7 @@ import {`
`6`	`6`	`import{ThemeProviderasEmotionThemeProvider}from"@emotion/react";`
`7`	`7`	`import{DecoratorHelpers}from"@storybook/addon-themes";`
`8`	`8`	`import{withRouter}from"storybook-addon-remix-react-router";`
	`9`	`+import{StrictMode}from"react";`
`9`	`10`	`import{QueryClient,QueryClientProvider}from"react-query";`
`10`	`11`	`import{HelmetProvider}from"react-helmet-async";`
`11`	`12`	`importthemesfrom"theme";`
`@@ -29,14 +30,16 @@ export const decorators = [`
`29`	`30`	`constselected=themeOverride\|\|selectedTheme\|\|"dark";`
`30`	`31`
`31`	`32`	`return(`
`32`		`-<StyledEngineProviderinjectFirst>`
`33`		`-<MuiThemeProvidertheme={themes[selected]}>`
`34`		`-<EmotionThemeProvidertheme={themes[selected]}>`
`35`		`-<CssBaseline/>`
`36`		`-<Story/>`
`37`		`-</EmotionThemeProvider>`
`38`		`-</MuiThemeProvider>`
`39`		`-</StyledEngineProvider>`
	`33`	`+<StrictMode>`
	`34`	`+<StyledEngineProviderinjectFirst>`
	`35`	`+<MuiThemeProvidertheme={themes[selected]}>`
	`36`	`+<EmotionThemeProvidertheme={themes[selected]}>`
	`37`	`+<CssBaseline/>`
	`38`	`+<Story/>`
	`39`	`+</EmotionThemeProvider>`
	`40`	`+</MuiThemeProvider>`
	`41`	`+</StyledEngineProvider>`
	`42`	`+</StrictMode>`
`40`	`43`	`);`
`41`	`44`	`},`
`42`	`45`	`];`

Lines changed: 14 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,12 @@`
`1`	`1`	`import"./theme/globalFonts";`
`2`	`2`	`import{ReactQueryDevtools}from"@tanstack/react-query-devtools";`
`3`		`-import{typeFC,typeReactNode,useEffect,useState}from"react";`
	`3`	`+import{`
	`4`	`+typeFC,`
	`5`	`+typeReactNode,`
	`6`	`+StrictMode,`
	`7`	`+useEffect,`
	`8`	`+useState,`
	`9`	`+}from"react";`
`4`	`10`	`import{HelmetProvider}from"react-helmet-async";`
`5`	`11`	`import{QueryClient,QueryClientProvider}from"react-query";`
`6`	`12`	`import{RouterProvider}from"react-router-dom";`
`@@ -74,10 +80,12 @@ export const AppProviders: FC<AppProvidersProps> = ({`
`74`	`80`
`75`	`81`	`exportconstApp:FC=()=>{`
`76`	`82`	`return(`
`77`		`-<ErrorBoundary>`
`78`		`-<AppProviders>`
`79`		`-<RouterProviderrouter={router}/>`
`80`		`-</AppProviders>`
`81`		`-</ErrorBoundary>`
	`83`	`+<StrictMode>`
	`84`	`+<ErrorBoundary>`
	`85`	`+<AppProviders>`
	`86`	`+<RouterProviderrouter={router}/>`
	`87`	`+</AppProviders>`
	`88`	`+</ErrorBoundary>`
	`89`	`+</StrictMode>`
`82`	`90`	`);`
`83`	`91`	`};`

Lines changed: 7 additions & 13 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,22 +1,16 @@`
`1`	`1`	`import{createRoot}from"react-dom/client";`
`2`	`2`	`import{App}from"./App";`
`3`	`3`
`4`		`-// This is the entry point for the app - where everything start.`
`5`		`-// In the future, we'll likely bring in more bootstrapping logic -`
`6`		`-// like: https://github.com/coder/m/blob/50898bd4803df7639bd181e484c74ac5d84da474/product/coder/site/pages/_app.tsx#L32`
`7`		`-constmain=()=>{`
`8`		-console.info(` ▄█▀ ▀█▄
	`4`	+console.info(` ▄█▀ ▀█▄
`9`	`5`	`▄▄ ▀▀▀ █▌ ██▀▀█▄ ▐█`
`10`	`6`	`▄▄██▀▀█▄▄▄ ██ ██ █▀▀█ ▐█▀▀██ ▄█▀▀█ █▀▀`
`11`	`7`	`█▌ ▄▌ ▐█ █▌ ▀█▄▄▄█▌ █ █ ▐█ ██ ██▀▀ █`
`12`	`8`	`██████▀▄█ ▀▀▀▀ ▀▀▀▀ ▀▀▀▀▀ ▀▀▀▀ ▀`
`13`	`9`	`);
`14`		`-constelement=document.getElementById("root");`
`15`		`-if(element===null){`
`16`		`-thrownewError("root element is null");`
`17`		`-}`
`18`		`-constroot=createRoot(element);`
`19`		`-root.render(<App/>);`
`20`		`-};`
`21`	`10`
`22`		`-main();`
	`11`	`+constelement=document.getElementById("root");`
	`12`	`+if(element===null){`
	`13`	`+thrownewError("root element is null");`
	`14`	`+}`
	`15`	`+constroot=createRoot(element);`
	`16`	`+root.render(<App/>);`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -206,9 +206,8 @@ export const UserDropdownContent: FC<UserDropdownContentProps> = ({`
`206`	`206`	`<Dividercss={{marginBottom:"0 !important"}}/>`
`207`	`207`
`208`	`208`	`<Stackcss={styles.info}spacing={0}>`
`209`		`-<Tooltiptitle="Coder Version">`
	`209`	`+<Tooltiptitle="Browse the source code">`
`210`	`210`	`<a`
`211`		`-title="Browse Source Code"`
`212`	`211`	`css={[styles.footerText,styles.buildInfo]}`
`213`	`212`	`href={buildInfo?.external_url}`
`214`	`213`	`target="_blank"`

Comments

(0)