NotificationsYou must be signed in to change notification settings
Fork1k
Star11.1k

Commit76d6e13

authored

ci: makechanges required (#20131)

Earlier today, a dependabot PR was merged despite CI not having been run.#20068This was because the `changes` job failed due to a github ratelimit, which caused all the tests to be skipped, which caused `required` to pass as it passes if tests are skipped.<img width="725" height="872" alt="image" src="https://github.com/user-attachments/assets/3a13d19b-819a-48df-ad8c-e9ff903a0496" />This PR makes `changes` required so this can't happen again (assuming we keep around the dependabot automerge around, it might).

1 parentf84a789 commit76d6e13Copy full SHA for 76d6e13

File tree

1 file changed

-0

lines changed

.github/workflows
- ci.yaml

1 file changed

-0

lines changed

`‎.github/workflows/ci.yaml‎`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -919,6 +919,7 @@ jobs:`
`919`	`919`	`required:`
`920`	`920`	`runs-on:ubuntu-latest`
`921`	`921`	`needs:`
	`922`	`+ -changes`
`922`	`923`	`-fmt`
`923`	`924`	`-lint`
`924`	`925`	`-gen`
`@@ -942,6 +943,7 @@ jobs:`
`942`	`943`	`-name:Ensure required checks`
`943`	`944`	`run:\|# zizmor: ignore[template-injection] We're just reading needs.x.result here, no risk of injection`
`944`	`945`	`echo "Checking required checks"`
	`946`	`+ echo "- changes: ${{ needs.changes.result }}"`
`945`	`947`	`echo "- fmt: ${{ needs.fmt.result }}"`
`946`	`948`	`echo "- lint: ${{ needs.lint.result }}"`
`947`	`949`	`echo "- gen: ${{ needs.gen.result }}"`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit76d6e13

File tree

1 file changed

1 file changed

`‎.github/workflows/ci.yaml‎`

0 commit comments