Commit755afa3

authored

chore: ui error handling should be specific to general (#14346)

* chore: ui error handling should be specific to generalSpecific errors should be checked before defaulting to a generalerror handling

1 parent422e044 commit755afa3Copy full SHA for 755afa3

File tree

+18

-6

lines changed

+18

-6

lines changed

Lines changed: 9 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -115,18 +115,21 @@ export const getErrorDetail = (error: unknown): string \| undefined => {`
`115`	`115`	`returnerror.detail;`
`116`	`116`	`}`
`117`	`117`
`118`		`-if(errorinstanceofError){`
`119`		`-return"Please check the developer console for more details.";`
`120`		`-}`
`121`		`-`
`122`		`-if(isApiError(error)){`
	`118`	`+// APIErrors that are empty still benefit from checking the developer`
	`119`	`+// console if no detail is provided. So only use the detail field if`
	`120`	`+// it is not empty.`
	`121`	`+if(isApiError(error)&&error.response.data.detail){`
`123`	`122`	`returnerror.response.data.detail;`
`124`	`123`	`}`
`125`	`124`
`126`		`-if(isApiErrorResponse(error)){`
	`125`	`+if(isApiErrorResponse(error)&&error.detail){`
`127`	`126`	`returnerror.detail;`
`128`	`127`	`}`
`129`	`128`
	`129`	`+if(errorinstanceofError){`
	`130`	`+return"Please check the developer console for more details.";`
	`131`	`+}`
	`132`	`+`
`130`	`133`	`returnundefined;`
`131`	`134`	`};`
`132`	`135`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,15 @@ export const WithOnlyMessage: Story = {`
`34`	`34`	`},`
`35`	`35`	`};`
`36`	`36`
	`37`	`+exportconstAPIErrorWithDetail:Story={`
	`38`	`+args:{`
	`39`	`+error:mockApiError({`
	`40`	`+message:"Magic dust is missing",`
	`41`	`+detail:"without magic dust, the requested operation will never work",`
	`42`	`+}),`
	`43`	`+},`
	`44`	`+};`
	`45`	`+`
`37`	`46`	`exportconstWithDismiss:Story={`
`38`	`47`	`args:{`
`39`	`48`	`dismissible:true,`

Comments

(0)