Commit7500aa4

authored

fix(cli): calculate coder ping max correctly (#18734)

Embarassing mistake I made months ago 😦 *Doesn't effect schmoder, since we don't parse that max, it calculates it itself

1 parent6db6f48 commit7500aa4Copy full SHA for 7500aa4

File tree

-3

lines changed

-3

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ func (s pingSummary) addResult(r ipnstate.PingResult) {`
`53`	`53`	`ifs.Min==nil\|\|r.LatencySeconds<s.Min.Seconds() {`
`54`	`54`	`s.Min=ptr.Ref(time.Duration(r.LatencySeconds*float64(time.Second)))`
`55`	`55`	`}`
`56`		`-ifs.Max==nil\|\|r.LatencySeconds>s.Min.Seconds() {`
	`56`	`+ifs.Max==nil\|\|r.LatencySeconds>s.Max.Seconds() {`
`57`	`57`	`s.Max=ptr.Ref(time.Duration(r.LatencySeconds*float64(time.Second)))`
`58`	`58`	`}`
`59`	`59`	`s.latencySum+=r.LatencySeconds`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -21,11 +21,11 @@ func TestBuildSummary(t *testing.T) {`
`21`	`21`	`},`
`22`	`22`	`{`
`23`	`23`	`Err:"",`
`24`		`-LatencySeconds:0.2,`
	`24`	`+LatencySeconds:0.3,`
`25`	`25`	`},`
`26`	`26`	`{`
`27`	`27`	`Err:"",`
`28`		`-LatencySeconds:0.3,`
	`28`	`+LatencySeconds:0.2,`
`29`	`29`	`},`
`30`	`30`	`{`
`31`	`31`	`Err:"ping error",`

Comments

(0)