NotificationsYou must be signed in to change notification settings
Fork1.1k
Star11.8k

Commit7152f4a

authored

ci: make sure golden files are actually up to date (#15989)

1 parent0e26a66 commit7152f4aCopy full SHA for 7152f4a

File tree

11 files changed

+37

-166

lines changed

.github/workflows
- ci.yaml
Makefile
cli/testdata
- coder_templates_plan_--help.golden
enterprise/cli/testdata
helm/provisioner/tests
- chart_test.go

11 files changed

+37

-166

lines changed

`‎.github/workflows/ci.yaml‎`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -271,6 +271,15 @@ jobs:`
`271`	`271`	`# coderd/rbac/object_gen.go:1:1: syntax error: package statement must be first`
`272`	`272`	`run:"make --output-sync -B gen"`
`273`	`273`
	`274`	`+ -name:make update-golden-files`
	`275`	`+run:\|`
	`276`	`+ make clean/golden-files`
	`277`	`+ # Notifications require DB, we could start a DB instance here but`
	`278`	`+ # let's just restore for now.`
	`279`	`+ git checkout -- coderd/notifications/testdata/rendered-templates`
	`280`	+ # As above, skip `-j` flag.
	`281`	`+ make --output-sync -B update-golden-files`
	`282`	`+`
`274`	`283`	`-name:Check for unstaged files`
`275`	`284`	`run:./scripts/check_unstaged.sh`
`276`	`285`

`‎Makefile‎`

Lines changed: 22 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -702,18 +702,33 @@ coderd/apidoc/swagger.json: $(shell find ./scripts/apidocgen $(FIND_EXCLUSIONS)`
`702`	`702`
`703`	`703`	`update-golden-files:\`
`704`	`704`	`cli/testdata/.gen-golden\`
`705`		`-helm/coder/tests/testdata/.gen-golden\`
`706`		`-helm/provisioner/tests/testdata/.gen-golden\`
`707`		`-enterprise/cli/testdata/.gen-golden\`
`708`		`-enterprise/tailnet/testdata/.gen-golden\`
`709`		`-tailnet/testdata/.gen-golden\`
`710`	`705`	`coderd/.gen-golden\`
`711`	`706`	`coderd/notifications/.gen-golden\`
`712`		`-provisioner/terraform/testdata/.gen-golden`
	`707`	`+enterprise/cli/testdata/.gen-golden\`
	`708`	`+enterprise/tailnet/testdata/.gen-golden\`
	`709`	`+helm/coder/tests/testdata/.gen-golden\`
	`710`	`+helm/provisioner/tests/testdata/.gen-golden\`
	`711`	`+provisioner/terraform/testdata/.gen-golden\`
	`712`	`+tailnet/testdata/.gen-golden`
`713`	`713`	`.PHONY: update-golden-files`
`714`	`714`
	`715`	`+clean/golden-files:`
	`716`	`+find. -type f -name'.gen-golden' -delete`
	`717`	`+find\`
	`718`	`+cli/testdata\`
	`719`	`+coderd/notifications/testdata\`
	`720`	`+coderd/testdata\`
	`721`	`+enterprise/cli/testdata\`
	`722`	`+enterprise/tailnet/testdata\`
	`723`	`+helm/coder/tests/testdata\`
	`724`	`+helm/provisioner/tests/testdata\`
	`725`	`+provisioner/terraform/testdata\`
	`726`	`+tailnet/testdata\`
	`727`	`+-type f -name'*.golden' -delete`
	`728`	`+.PHONY: clean/golden-files`
	`729`	`+`
`715`	`730`	`cli/testdata/.gen-golden:$(wildcard cli/testdata/.golden)$(wildcard cli/.tpl)$(GO_SRC_FILES)$(wildcard cli/*_test.go)`
`716`		`-gotest ./cli -run="Test(CommandHelp\|ServerYAML\|ErrorExamples)" -update`
	`731`	`+gotest ./cli -run="Test(CommandHelp\|ServerYAML\|ErrorExamples\|.*Golden)" -update`
`717`	`732`	`touch"$@"`
`718`	`733`
`719`	`734`	`enterprise/cli/testdata/.gen-golden:$(wildcard enterprise/cli/testdata/.golden)$(wildcard cli/.tpl)$(GO_SRC_FILES)$(wildcard enterprise/cli/*_test.go)`