NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

Commit704faa2

committed

update tests

1 parent829316b commit704faa2Copy full SHA for 704faa2

File tree

1 file changed

+13

-12

lines changed

enterprise/coderd
- groups_test.go

1 file changed

+13

-12

lines changed

`‎enterprise/coderd/groups_test.go`

Lines changed: 13 additions & 12 deletions

Original file line number	Diff line number	Diff line change
`@@ -613,8 +613,8 @@ func TestGroup(t *testing.T) {`
`613`	`613`	`AddUsers: []string{user2.ID.String(),user3.ID.String()},`
`614`	`614`	`})`
`615`	`615`	`require.NoError(t,err)`
`616`		`-require.Contains(t,group.Members,user2)`
`617`		`-require.Contains(t,group.Members,user3)`
	`616`	`+require.Contains(t,group.Members,user2.ReducedUser)`
	`617`	`+require.Contains(t,group.Members,user3.ReducedUser)`
`618`	`618`
`619`	`619`	`ggroup,err:=userAdminClient.Group(ctx,group.ID)`
`620`	`620`	`require.NoError(t,err)`
`@@ -665,15 +665,15 @@ func TestGroup(t *testing.T) {`
`665`	`665`	`AddUsers: []string{user1.ID.String(),user2.ID.String()},`
`666`	`666`	`})`
`667`	`667`	`require.NoError(t,err)`
`668`		`-require.Contains(t,group.Members,user1)`
`669`		`-require.Contains(t,group.Members,user2)`
	`668`	`+require.Contains(t,group.Members,user1.ReducedUser)`
	`669`	`+require.Contains(t,group.Members,user2.ReducedUser)`
`670`	`670`
`671`	`671`	`err=userAdminClient.DeleteUser(ctx,user1.ID)`
`672`	`672`	`require.NoError(t,err)`
`673`	`673`
`674`	`674`	`group,err=userAdminClient.Group(ctx,group.ID)`
`675`	`675`	`require.NoError(t,err)`
`676`		`-require.NotContains(t,group.Members,user1)`
	`676`	`+require.NotContains(t,group.Members,user1.ReducedUser)`
`677`	`677`	`})`
`678`	`678`
`679`	`679`	`t.Run("IncludeSuspendedAndDormantUsers",func(t*testing.T) {`
`@@ -700,17 +700,17 @@ func TestGroup(t *testing.T) {`
`700`	`700`	`})`
`701`	`701`	`require.NoError(t,err)`
`702`	`702`	`require.Len(t,group.Members,2)`
`703`		`-require.Contains(t,group.Members,user1)`
`704`		`-require.Contains(t,group.Members,user2)`
	`703`	`+require.Contains(t,group.Members,user1.ReducedUser)`
	`704`	`+require.Contains(t,group.Members,user2.ReducedUser)`
`705`	`705`
`706`	`706`	`user1,err=userAdminClient.UpdateUserStatus(ctx,user1.ID.String(),codersdk.UserStatusSuspended)`
`707`	`707`	`require.NoError(t,err)`
`708`	`708`
`709`	`709`	`group,err=userAdminClient.Group(ctx,group.ID)`
`710`	`710`	`require.NoError(t,err)`
`711`	`711`	`require.Len(t,group.Members,2)`
`712`		`-require.Contains(t,group.Members,user1)`
`713`		`-require.Contains(t,group.Members,user2)`
	`712`	`+require.Contains(t,group.Members,user1.ReducedUser)`
	`713`	`+require.Contains(t,group.Members,user2.ReducedUser)`
`714`	`714`
`715`	`715`	`// cannot explicitly set a dormant user status so must create a new user`
`716`	`716`	`anotherUser,err:=userAdminClient.CreateUser(ctx, codersdk.CreateUserRequest{`
`@@ -731,8 +731,8 @@ func TestGroup(t *testing.T) {`
`731`	`731`	`group,err=userAdminClient.Group(ctx,group.ID)`
`732`	`732`	`require.NoError(t,err)`
`733`	`733`	`require.Len(t,group.Members,3)`
`734`		`-require.Contains(t,group.Members,user1)`
`735`		`-require.Contains(t,group.Members,user2)`
	`734`	`+require.Contains(t,group.Members,user1.ReducedUser)`
	`735`	`+require.Contains(t,group.Members,user2.ReducedUser)`
`736`	`736`	`})`
`737`	`737`
`738`	`738`	`t.Run("everyoneGroupReturnsEmpty",func(t*testing.T) {`
`@@ -754,7 +754,8 @@ func TestGroup(t *testing.T) {`
`754`	`754`	`require.Len(t,group.Members,4)`
`755`	`755`	`require.Equal(t,"Everyone",group.Name)`
`756`	`756`	`require.Equal(t,user.OrganizationID,group.OrganizationID)`
`757`		`-require.Contains(t,group.Members,user1,user2)`
	`757`	`+require.Contains(t,group.Members,user1.ReducedUser)`
	`758`	`+require.Contains(t,group.Members,user2.ReducedUser)`
`758`	`759`	`})`
`759`	`760`	`}`
`760`	`761`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit704faa2

File tree

1 file changed

1 file changed

`‎enterprise/coderd/groups_test.go`

0 commit comments