NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

Commit6fde537

authored

web: use seconds in max TTL input (#3576)

Milliseconds are more difficult to deal with due toall of the zeros.Also, describe this feature as "auto-stop" to beconsistent with our Workspace page UI and CLI. "ttl"is our backend lingo which should eventually be updated.

1 parent5e36be8 commit6fde537Copy full SHA for 6fde537

File tree

1 file changed

-5

lines changed

site/src/pages/TemplateSettingsPage
- TemplateSettingsForm.tsx

1 file changed

-5

lines changed

`‎site/src/pages/TemplateSettingsPage/TemplateSettingsForm.tsx`

Lines changed: 9 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -18,10 +18,10 @@ import * as Yup from "yup"`
`18`	`18`	`exportconstLanguage={`
`19`	`19`	`nameLabel:"Name",`
`20`	`20`	`descriptionLabel:"Description",`
	`21`	`+maxTtlLabel:"Auto-stop limit",`
`21`	`22`	`iconLabel:"Icon",`
`22`		`-maxTtlLabel:"Max TTL",`
`23`	`23`	`// This is the same from the CLI on https://github.com/coder/coder/blob/546157b63ef9204658acf58cb653aa9936b70c49/cli/templateedit.go#L59`
`24`		`-maxTtlHelperText:"Edit the template maximum time before shutdown inmilliseconds",`
	`24`	`+maxTtlHelperText:"Edit the template maximum time before shutdown inseconds",`
`25`	`25`	`formAriaLabel:"Template settings form",`
`26`	`26`	`selectEmoji:"Select emoji",`
`27`	`27`	`}`
`@@ -59,9 +59,7 @@ export const TemplateSettingsForm: FC<TemplateSettingsForm> = ({`
`59`	`59`	`icon:template.icon,`
`60`	`60`	`},`
`61`	`61`	`validationSchema,`
`62`		`-onSubmit:(data)=>{`
`63`		`-onSubmit(data)`
`64`		`-},`
	`62`	`+ onSubmit,`
`65`	`63`	`initialTouched,`
`66`	`64`	`})`
`67`	`65`	`constgetFieldHelpers=getFormHelpersWithError<UpdateTemplateMeta>(form,error)`
`@@ -156,6 +154,12 @@ export const TemplateSettingsForm: FC<TemplateSettingsForm> = ({`
`156`	`154`	`inputProps={{min:0,step:1}}`
`157`	`155`	`label={Language.maxTtlLabel}`
`158`	`156`	`variant="outlined"`
	`157`	`+// Display seconds from ms`
	`158`	`+value={form.values.max_ttl_ms ?form.values.max_ttl_ms/1000 :""}`
	`159`	`+// Convert ms to seconds`
	`160`	`+onChange={(event)=>`
	`161`	`+form.setFieldValue("max_ttl_ms",Number(event.currentTarget.value)*1000)`
	`162`	`+}`
`159`	`163`	`/>`
`160`	`164`	`</Stack>`
`161`	`165`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6fde537

File tree

1 file changed

1 file changed

`‎site/src/pages/TemplateSettingsPage/TemplateSettingsForm.tsx`

0 commit comments