Movatterモバイル変換

Skip to content

coder/coderPublic

NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

Commit6fd5344

ffais

ericpaulsen

and

authored

feat: add support for NodePort service type in Helm chart (#8993)

* add support for NodePort service type in Helm chart* fix nodeport values* formatting & make update-golden-files* update-golden-files---------Co-authored-by: Eric <ericpaulsen@coder.com>

1 parenta2d64c0 commit6fd5344Copy full SHA for 6fd5344

File tree

10 files changed

+21

-0

lines changed

helm/coder
- templates
  - service.yaml
- tests/testdata
- values.yaml

10 files changed

+21

-0

lines changed

`‎helm/coder/templates/service.yaml`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -16,11 +16,17 @@ spec:`
`16`	`16`	`port:80`
`17`	`17`	`targetPort:"http"`
`18`	`18`	`protocol:TCP`
	`19`	`+{{ if eq .Values.coder.service.type "NodePort" }}`
	`20`	`+nodePort:{{ .Values.coder.service.httpNodePort }}`
	`21`	`+{{ end }}`
`19`	`22`	`{{- if eq (include "coder.tlsEnabled" .) "true" }}`
`20`	`23`	`-name:"https"`
`21`	`24`	`port:443`
`22`	`25`	`targetPort:"https"`
`23`	`26`	`protocol:TCP`
	`27`	`+{{ if eq .Values.coder.service.type "NodePort" }}`
	`28`	`+nodePort:{{ .Values.coder.service.httpsNodePort }}`
	`29`	`+{{ end }}`
`24`	`30`	`{{- end }}`
`25`	`31`	`{{- if eq "LoadBalancer" .Values.coder.service.type }}`
`26`	`32`	`{{- with .Values.coder.service.loadBalancerIP }}`

`‎helm/coder/tests/testdata/command.golden`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -90,6 +90,7 @@ spec:`
`90`	`90`	`port: 80`
`91`	`91`	`targetPort: "http"`
`92`	`92`	`protocol: TCP`
	`93`	`+`
`93`	`94`	`externalTrafficPolicy: "Cluster"`
`94`	`95`	`selector:`
`95`	`96`	`app.kubernetes.io/name: coder`

`‎helm/coder/tests/testdata/command_args.golden`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -90,6 +90,7 @@ spec:`
`90`	`90`	`port: 80`
`91`	`91`	`targetPort: "http"`
`92`	`92`	`protocol: TCP`
	`93`	`+`
`93`	`94`	`externalTrafficPolicy: "Cluster"`
`94`	`95`	`selector:`
`95`	`96`	`app.kubernetes.io/name: coder`

`‎helm/coder/tests/testdata/default_values.golden`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -90,6 +90,7 @@ spec:`
`90`	`90`	`port: 80`
`91`	`91`	`targetPort: "http"`
`92`	`92`	`protocol: TCP`
	`93`	`+`
`93`	`94`	`externalTrafficPolicy: "Cluster"`
`94`	`95`	`selector:`
`95`	`96`	`app.kubernetes.io/name: coder`

`‎helm/coder/tests/testdata/labels_annotations.golden`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -90,6 +90,7 @@ spec:`
`90`	`90`	`port: 80`
`91`	`91`	`targetPort: "http"`
`92`	`92`	`protocol: TCP`
	`93`	`+`
`93`	`94`	`externalTrafficPolicy: "Cluster"`
`94`	`95`	`selector:`
`95`	`96`	`app.kubernetes.io/name: coder`

`‎helm/coder/tests/testdata/provisionerd_psk.golden`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -90,6 +90,7 @@ spec:`
`90`	`90`	`port: 80`
`91`	`91`	`targetPort: "http"`
`92`	`92`	`protocol: TCP`
	`93`	`+`
`93`	`94`	`externalTrafficPolicy: "Cluster"`
`94`	`95`	`selector:`
`95`	`96`	`app.kubernetes.io/name: coder`

`‎helm/coder/tests/testdata/sa.golden`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -91,6 +91,7 @@ spec:`
`91`	`91`	`port: 80`
`92`	`92`	`targetPort: "http"`
`93`	`93`	`protocol: TCP`
	`94`	`+`
`94`	`95`	`externalTrafficPolicy: "Cluster"`
`95`	`96`	`selector:`
`96`	`97`	`app.kubernetes.io/name: coder`

`‎helm/coder/tests/testdata/tls.golden`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -90,10 +90,12 @@ spec:`
`90`	`90`	`port: 80`
`91`	`91`	`targetPort: "http"`
`92`	`92`	`protocol: TCP`
	`93`	`+`
`93`	`94`	`- name: "https"`
`94`	`95`	`port: 443`
`95`	`96`	`targetPort: "https"`
`96`	`97`	`protocol: TCP`
	`98`	`+`
`97`	`99`	`externalTrafficPolicy: "Cluster"`
`98`	`100`	`selector:`
`99`	`101`	`app.kubernetes.io/name: coder`

`‎helm/coder/tests/testdata/workspace_proxy.golden`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -90,6 +90,7 @@ spec:`
`90`	`90`	`port: 80`
`91`	`91`	`targetPort: "http"`
`92`	`92`	`protocol: TCP`
	`93`	`+`
`93`	`94`	`externalTrafficPolicy: "Cluster"`
`94`	`95`	`selector:`
`95`	`96`	`app.kubernetes.io/name: coder`

`‎helm/coder/values.yaml`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -241,6 +241,12 @@ coder:`
`241`	`241`	`# coder.service.annotations -- The service annotations. See:`
`242`	`242`	`# https://kubernetes.io/docs/concepts/services-networking/service/#internal-load-balancer`
`243`	`243`	`annotations:{}`
	`244`	`+# coder.service.httpNodePort -- Enabled if coder.service.type is set to NodePort.`
	`245`	`+# If not set, Kubernetes will allocate a port from the default range, 30000-32767.`
	`246`	`+httpNodePort:""`
	`247`	`+# coder.service.httpsNodePort -- Enabled if coder.service.type is set to NodePort.`
	`248`	`+# If not set, Kubernetes will allocate a port from the default range, 30000-32767.`
	`249`	`+httpsNodePort:""`
`244`	`250`
`245`	`251`	`# coder.ingress -- The Ingress object to expose for Coder.`
`246`	`252`	`ingress:`

0 commit comments

Comments

(0)

[8]ページ先頭

©2009-2025 Movatter.jp