Commit6d2b7ea

authored

fix(audit): only generate diff on request success (#4253)

1 parent9339d59 commit6d2b7eaCopy full SHA for 6d2b7ea

File tree

+12

-2

lines changed

+12

-2

lines changed

Lines changed: 12 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -110,8 +110,18 @@ func InitRequest[T Auditable](w http.ResponseWriter, p RequestParams) (Request`
`110`	`110`	`return`
`111`	`111`	`}`
`112`	`112`
`113`		`-diff:=Diff(p.Audit,req.Old,req.New)`
`114`		`-diffRaw,_:=json.Marshal(diff)`
	`113`	`+vardiffRaw= []byte("{}")`
	`114`	`+// Only generate diffs if the request succeeded.`
	`115`	`+ifsw.Status<400 {`
	`116`	`+diff:=Diff(p.Audit,req.Old,req.New)`
	`117`	`+`
	`118`	`+varerrerror`
	`119`	`+diffRaw,err=json.Marshal(diff)`
	`120`	`+iferr!=nil {`
	`121`	`+p.Log.Warn(logCtx,"marshal diff",slog.Error(err))`
	`122`	`+diffRaw= []byte("{}")`
	`123`	`+}`
	`124`	`+}`
`115`	`125`
`116`	`126`	`ip,err:=parseIP(p.Request.RemoteAddr)`
`117`	`127`	`iferr!=nil {`

Comments

(0)