Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit6cff359

Browse files
committed
fix(site): set min and max attributes for workspace number parameters
1 parentc8f68cb commit6cff359

File tree

3 files changed

+63
-0
lines changed

3 files changed

+63
-0
lines changed

‎site/src/components/RichParameterInput/RichParameterInput.stories.tsx‎

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,38 @@ export const NumberType: Story = {
9999
},
100100
};
101101

102+
exportconstNumberTypeWithIncreasingMonotonicity:Story={
103+
args:{
104+
value:4,
105+
id:"number_parameter",
106+
parameter:createTemplateVersionParameter({
107+
name:"number_parameter",
108+
type:"number",
109+
description:"Numeric parameter",
110+
default_value:"",
111+
validation_min:0,
112+
validation_max:10,
113+
validation_monotonic:"increasing",
114+
}),
115+
},
116+
};
117+
118+
exportconstNumberTypeWithDecreasingMonotonicity:Story={
119+
args:{
120+
value:4,
121+
id:"number_parameter",
122+
parameter:createTemplateVersionParameter({
123+
name:"number_parameter",
124+
type:"number",
125+
description:"Numeric parameter",
126+
default_value:"",
127+
validation_min:0,
128+
validation_max:10,
129+
validation_monotonic:"decreasing",
130+
}),
131+
},
132+
};
133+
102134
exportconstBooleanType:Story={
103135
args:{
104136
value:"false",

‎site/src/components/RichParameterInput/RichParameterInput.tsx‎

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import type {
1818
AutofillSource,
1919
}from"utils/richParameters";
2020
import{MultiTextField}from"./MultiTextField";
21+
import{InputBaseComponentProps}from"@mui/material";
2122

2223
constisBoolean=(parameter:TemplateVersionParameter)=>{
2324
returnparameter.type==="bool";
@@ -217,6 +218,7 @@ export const RichParameterInput: FC<RichParameterInputProps> = ({
217218
onChange={onChange}
218219
size={size}
219220
parameter={parameter}
221+
parameterAutofill={parameterAutofill}
220222
/>
221223
{!parameter.ephemeral&&
222224
autofillSource==="user_history"&&
@@ -250,6 +252,7 @@ const RichParameterField: FC<RichParameterInputProps> = ({
250252
disabled,
251253
onChange,
252254
parameter,
255+
parameterAutofill,
253256
value,
254257
size,
255258
...props
@@ -375,6 +378,30 @@ const RichParameterField: FC<RichParameterInputProps> = ({
375378
);
376379
}
377380

381+
letinputProps:InputBaseComponentProps={};
382+
if(parameter.type==="number"){
383+
switch(parameter.validation_monotonic){
384+
case"increasing":
385+
inputProps={
386+
max:parameter.validation_max,
387+
min:parameterAutofill?.value,
388+
};
389+
break;
390+
case"decreasing":
391+
inputProps={
392+
max:parameterAutofill?.value,
393+
min:parameter.validation_min,
394+
};
395+
break;
396+
default:
397+
inputProps={
398+
max:parameter.validation_max,
399+
min:parameter.validation_min,
400+
};
401+
break;
402+
}
403+
}
404+
378405
// A text field can technically handle all cases!
379406
// As other cases become more prominent (like filtering for numbers),
380407
// we should break this out into more finely scoped input fields.
@@ -389,6 +416,7 @@ const RichParameterField: FC<RichParameterInputProps> = ({
389416
required={parameter.required}
390417
placeholder={parameter.default_value}
391418
value={value}
419+
inputProps={inputProps}
392420
onChange={(event)=>{
393421
onChange(event.target.value);
394422
}}

‎site/src/pages/WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersForm.tsx‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,9 @@ export const WorkspaceParametersForm: FC<WorkspaceParameterFormProps> = ({
112112
);
113113
}}
114114
parameter={parameter}
115+
parameterAutofill={autofillParams?.find(
116+
({ name})=>name===parameter.name,
117+
)}
115118
/>
116119
) :null,
117120
)}

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp