NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

Commit6cf483b

authored

fix: allow server startup without tunnel (#2380)

- Previously, specifying 'no' to the tunnel prompt just killed the process. It should be possible to start the server without a tunnel and not have the process killed.

1 parent9b3b641 commit6cf483bCopy full SHA for 6cf483b

File tree

1 file changed

-1

lines changed

cli
- server.go

1 file changed

-1

lines changed

`‎cli/server.go`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -192,9 +192,13 @@ func server() *cobra.Command {`
`192`	`192`	`Text:"Would you like to start a tunnel for simple setup?",`
`193`	`193`	`IsConfirm:true,`
`194`	`194`	`})`
`195`		`-iferrors.Is(err,cliui.Canceled) {`
	`195`	`+`
	`196`	`+iferr!=nil&&!errors.Is(err,cliui.Canceled) {`
`196`	`197`	`returnerr`
`197`	`198`	`}`
	`199`	`+`
	`200`	`+// Don't tunnel if the user specifies no tunnel.`
	`201`	`+tunnel=!errors.Is(err,cliui.Canceled)`
`198`	`202`	`}`
`199`	`203`	`iferr==nil {`
`200`	`204`	`devTunnel,devTunnelErrChan,err=devtunnel.New(ctxTunnel,logger.Named("devtunnel"))`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6cf483b

File tree

1 file changed

1 file changed

`‎cli/server.go`

0 commit comments