Commit6ba92ef

authored

ci: enable gocognit (#9359)

And, bring the server under 300:* Removed the undocumented "disable" STUN address in favor of the--disable-direct flag.

1 parent173aac9 commit6ba92efCopy full SHA for 6ba92ef

File tree

+264

-273

lines changed

+264

-273

lines changed

Lines changed: 6 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ linters-settings:`
`11`	`11`	`# Gradually extend to cover more of the codebase.`
`12`	`12`	`-'httpmw\.\w+'`
`13`	`13`	`gocognit:`
`14`		`-min-complexity:46# Min code complexity (def 30).`
	`14`	`+min-complexity:300`
`15`	`15`
`16`	`16`	`goconst:`
`17`	`17`	`min-len:4# Min length of string consts (def 3).`
`@@ -122,10 +122,6 @@ linters-settings:`
`122`	`122`	`goimports:`
`123`	`123`	`local-prefixes:coder.com,cdr.dev,go.coder.com,github.com/cdr,github.com/coder`
`124`	`124`
`125`		`-gocyclo:`
`126`		`-# goal: 30`
`127`		`-min-complexity:47`
`128`		`-`
`129`	`125`	`importas:`
`130`	`126`	`no-unaliased:true`
`131`	`127`
`@@ -236,7 +232,11 @@ linters:`
`236`	`232`	`-exportloopref`
`237`	`233`	`-forcetypeassert`
`238`	`234`	`-gocritic`
`239`		`- -gocyclo`
	`235`	`+# gocyclo is may be useful in the future when we start caring`
	`236`	`+# about testing complexity, but for the time being we should`
	`237`	`+# create a good culture around cognitive complexity.`
	`238`	`+# - gocyclo`
	`239`	`+ -gocognit`
`240`	`240`	`-goimports`
`241`	`241`	`-gomodguard`
`242`	`242`	`-gosec`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -190,7 +190,6 @@ func sshPrepareWorkspaceConfigs(ctx context.Context, client *codersdk.Client) (r`
`190`	`190`	`}`
`191`	`191`	`}`
`192`	`192`
`193`		`-//nolint:gocyclo`
`194`	`193`	`func (rRootCmd)configSSH()clibase.Cmd {`
`195`	`194`	`var (`
`196`	`195`	`sshConfigFilestring`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -831,6 +831,13 @@ func (r RootCmd) checkWarnings(i clibase.Invocation, client *codersdk.Client)`
`831`	`831`	`returnnil`
`832`	`832`	`}`
`833`	`833`
	`834`	`+// Verbosef logs a message if verbose mode is enabled.`
	`835`	`+func (rRootCmd)Verbosef(invclibase.Invocation,fmtStrstring,args...interface{}) {`
	`836`	`+ifr.verbose {`
	`837`	`+cliui.Infof(inv.Stdout,fmtStr,args...)`
	`838`	`+}`
	`839`	`+}`
	`840`	`+`
`834`	`841`	`typeheaderTransportstruct {`
`835`	`842`	`transport http.RoundTripper`
`836`	`843`	`header http.Header`

Comments

(0)