Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit6929b62

Browse files
committed
chore: remove pingWebSocket since yamux runs keepalives
1 parent4ed1f55 commit6929b62

File tree

1 file changed

+1
-47
lines changed

1 file changed

+1
-47
lines changed

‎codersdk/agentsdk/agentsdk.go‎

Lines changed: 1 addition & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -205,16 +205,12 @@ func (c *Client) Listen(ctx context.Context) (drpc.Conn, error) {
205205
returnnil,codersdk.ReadBodyAsError(res)
206206
}
207207

208-
ctx,cancelFunc:=context.WithCancel(ctx)
209-
ctx,wsNetConn:=websocketNetConn(ctx,conn,websocket.MessageBinary)
210-
pingClosed:=pingWebSocket(ctx,c.SDK.Logger(),conn,"coordinate")
208+
_,wsNetConn:=websocketNetConn(ctx,conn,websocket.MessageBinary)
211209

212210
netConn:=&closeNetConn{
213211
Conn:wsNetConn,
214212
closeFunc:func() {
215-
cancelFunc()
216213
_=conn.Close(websocket.StatusGoingAway,"Listen closed")
217-
<-pingClosed
218214
},
219215
}
220216
config:=yamux.DefaultConfig()
@@ -720,45 +716,3 @@ func (c *closeNetConn) Close() error {
720716
c.closeFunc()
721717
returnc.Conn.Close()
722718
}
723-
724-
funcpingWebSocket(ctx context.Context,logger slog.Logger,conn*websocket.Conn,namestring)<-chanstruct{} {
725-
// Ping once every 30 seconds to ensure that the websocket is alive. If we
726-
// don't get a response within 30s we kill the websocket and reconnect.
727-
// See: https://github.com/coder/coder/pull/5824
728-
closed:=make(chanstruct{})
729-
gofunc() {
730-
deferclose(closed)
731-
tick:=30*time.Second
732-
ticker:=time.NewTicker(tick)
733-
deferticker.Stop()
734-
deferfunc() {
735-
logger.Debug(ctx,fmt.Sprintf("%s pinger exited",name))
736-
}()
737-
for {
738-
select {
739-
case<-ctx.Done():
740-
return
741-
casestart:=<-ticker.C:
742-
ctx,cancel:=context.WithTimeout(ctx,tick)
743-
744-
err:=conn.Ping(ctx)
745-
iferr!=nil {
746-
logger.Error(ctx,fmt.Sprintf("workspace agent %s ping",name),slog.Error(err))
747-
748-
err:=conn.Close(websocket.StatusGoingAway,"Ping failed")
749-
iferr!=nil {
750-
logger.Error(ctx,fmt.Sprintf("close workspace agent %s websocket",name),slog.Error(err))
751-
}
752-
753-
cancel()
754-
return
755-
}
756-
757-
logger.Debug(ctx,fmt.Sprintf("got %s ping",name),slog.F("took",time.Since(start)))
758-
cancel()
759-
}
760-
}
761-
}()
762-
763-
returnclosed
764-
}

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp