Commit6898381

committed

amend pr feedback

1 parentf8f496c commit6898381Copy full SHA for 6898381

File tree

+24

-4

lines changed

+24

-4

lines changed

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ func promoteVersionToStable(ctx context.Context, inv *serpent.Invocation, logger`
`96`	`96`	`// Check if the version is already the latest stable release.`
`97`	`97`	`currentStable,_,err:=client.Repositories.GetLatestRelease(ctx,"coder","coder")`
`98`	`98`	`iferr!=nil {`
`99`		`-returnerr`
	`99`	`+returnxerrors.Errorf("get latest release failed: %w",err)`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`logger=logger.With(slog.F("stable_version",currentStable.GetTagName()))`
`@@ -113,7 +113,7 @@ func promoteVersionToStable(ctx context.Context, inv *serpent.Invocation, logger`
`113`	`113`	`PerPage:perPage,`
`114`	`114`	`})`
`115`	`115`	`iferr!=nil {`
`116`		`-returnerr`
	`116`	`+returnxerrors.Errorf("list releases failed: %w",err)`
`117`	`117`	`}`
`118`	`118`
`119`	`119`	`varreleaseVersions []string`
`@@ -164,9 +164,9 @@ func promoteVersionToStable(ctx context.Context, inv *serpent.Invocation, logger`
`164`	`164`	`if!dryRun {`
`165`	`165`	`_,_,err=client.Repositories.EditRelease(ctx,owner,repo,newStable.GetID(),newStable)`
`166`	`166`	`iferr!=nil {`
`167`		`-returnerr`
	`167`	`+returnxerrors.Errorf("edit release failed: %w",err)`
`168`	`168`	`}`
`169`		`-logger.Info(ctx,"selected version promoted to stable")`
	`169`	`+logger.Info(ctx,"selected version promoted to stable","url",newStable.GetHTMLURL())`
`170`	`170`	`}else {`
`171`	`171`	`logger.Info(ctx,"dry-run: release not updated","uncommitted_changes",cmp.Diff(newStable,updatedNewStable))`
`172`	`172`	`}`

Lines changed: 20 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -86,6 +86,26 @@ Compare: [` + "`" + `v2.10.1...v2.10.2` + "`" + `](https://github.com/coder/code
`86`	`86`	`## Install/upgrade`
`87`	`87`
`88`	`88`	`Refer to our docs to [install](https://coder.com/docs/v2/latest/install) or [upgrade](https://coder.com/docs/v2/latest/admin/upgrade) Coder, or use a release asset below.`
	`89`	+`,
	`90`	`+},`
	`91`	`+{`
	`92`	`+name:"EntireQuotedBlurbIsRemoved",`
	`93`	+body:`## Changelog
	`94`	`+`
	`95`	`+> [!NOTE]`
	`96`	`+> This is a mainline Coder release. We advise enterprise customers without a staging environment to install our [latest stable release](https://github.com/coder/coder/releases/latest) while we refine this version. Learn more about our [Release Schedule](https://coder.com/docs/v2/latest/install/releases).`
	`97`	`+> This is an extended note.`
	`98`	`+> This is another extended note.`
	`99`	`+`
	`100`	`+### Best release yet!`
	`101`	`+`
	`102`	`+Enjoy.`
	`103`	+`,
	`104`	+want:`## Changelog
	`105`	`+`
	`106`	`+### Best release yet!`
	`107`	`+`
	`108`	`+Enjoy.`
`89`	`109`	`,
`90`	`110`	`},`
`91`	`111`	`}`

Comments

(0)