Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit647ffa1

Browse files
fix(coderd): ensure agent WebSocket conn is cleaned up
1 parent8f72538 commit647ffa1

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

‎coderd/workspaceagents.go‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -815,8 +815,9 @@ func (api *API) workspaceAgentListeningPorts(rw http.ResponseWriter, r *http.Req
815815
// @Router /workspaceagents/{workspaceagent}/containers/watch [get]
816816
func (api*API)watchWorkspaceAgentContainers(rw http.ResponseWriter,r*http.Request) {
817817
var (
818-
ctx=r.Context()
818+
ctx,cancelCtx=context.WithCancel(r.Context())
819819
workspaceAgent=httpmw.WorkspaceAgentParam(r)
820+
logger=api.Logger.Named("agent_container_watcher").With(slog.F("agent_id",workspaceAgent.ID))
820821
)
821822

822823
// If the agent is unreachable, the request will hang. Assume that if we
@@ -857,8 +858,7 @@ func (api *API) watchWorkspaceAgentContainers(rw http.ResponseWriter, r *http.Re
857858
}
858859
deferrelease()
859860

860-
watcherLogger:=api.Logger.Named("agent_container_watcher").With(slog.F("agent_id",workspaceAgent.ID))
861-
containersCh,closer,err:=agentConn.WatchContainers(ctx,watcherLogger)
861+
containersCh,closer,err:=agentConn.WatchContainers(ctx,logger)
862862
iferr!=nil {
863863
httpapi.Write(ctx,rw,http.StatusInternalServerError, codersdk.Response{
864864
Message:"Internal error watching agent's containers.",
@@ -881,11 +881,11 @@ func (api *API) watchWorkspaceAgentContainers(rw http.ResponseWriter, r *http.Re
881881
// close frames.
882882
_=conn.CloseRead(context.Background())
883883

884+
gohttpapi.HeartbeatClose(ctx,logger,cancelCtx,conn)
885+
884886
ctx,wsNetConn:=codersdk.WebsocketNetConn(ctx,conn,websocket.MessageText)
885887
deferwsNetConn.Close()
886888

887-
gohttpapi.Heartbeat(ctx,conn)
888-
889889
encoder:=json.NewEncoder(wsNetConn)
890890

891891
for {

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp