Commit63934b4

committed

fix(oauth2): allow custom URI schemes without reverse domain notation for native apps

Change-Id: I4000cd39caa994efe0b76c4984e968f2963063caSigned-off-by: Thomas Kosiewski <tk@coder.com>

1 parent13de8e2 commit63934b4Copy full SHA for 63934b4

File tree

-8

lines changed

-8

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ func (c *Client) OAuth2ProviderApp(ctx context.Context, id uuid.UUID) (OAuth2Pro`
`93`	`93`
`94`	`94`	`typePostOAuth2ProviderAppRequeststruct {`
`95`	`95`	Namestring`json:"name" validate:"required,oauth2_app_display_name"`
`96`		-RedirectURIs []string`json:"redirect_uris" validate:"dive,http_url"`
	`96`	+RedirectURIs []string`json:"redirect_uris" validate:"dive,uri"`
`97`	`97`	Iconstring`json:"icon" validate:"omitempty"`
`98`	`98`	GrantTypes []OAuth2ProviderGrantType`json:"grant_types,omitempty" validate:"dive,oneof=authorization_code refresh_token client_credentials urn:ietf:params:oauth:grant-type:device_code"`
`99`	`99`	`}`
`@@ -150,7 +150,7 @@ func (c *Client) PostOAuth2ProviderApp(ctx context.Context, app PostOAuth2Provid`
`150`	`150`
`151`	`151`	`typePutOAuth2ProviderAppRequeststruct {`
`152`	`152`	Namestring`json:"name" validate:"required,oauth2_app_display_name"`
`153`		-RedirectURIs []string`json:"redirect_uris" validate:"dive,http_url"`
	`153`	+RedirectURIs []string`json:"redirect_uris" validate:"dive,uri"`
`154`	`154`	Iconstring`json:"icon" validate:"omitempty"`
`155`	`155`	GrantTypes []OAuth2ProviderGrantType`json:"grant_types,omitempty" validate:"dive,oneof=authorization_code refresh_token client_credentials urn:ietf:params:oauth:grant-type:device_code"`
`156`	`156`	`}`

Lines changed: 0 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -257,12 +257,6 @@ func isLoopbackAddress(hostname string) bool {`
`257`	`257`
`258`	`258`	`// isValidCustomScheme validates custom schemes for public clients (RFC 8252)`
`259`	`259`	`funcisValidCustomScheme(schemestring)bool {`
`260`		`-// For security and RFC compliance, require reverse domain notation`
`261`		`-// Should contain at least one period and not be a well-known scheme`
`262`		`-if!strings.Contains(scheme,".") {`
`263`		`-returnfalse`
`264`		`-}`
`265`		`-`
`266`	`260`	`// Block schemes that look like well-known protocols`
`267`	`261`	`wellKnownSchemes:= []string{"http","https","ftp","mailto","tel","sms"}`
`268`	`262`	`for_,wellKnown:=rangewellKnownSchemes {`

Comments

(0)