Commit62b8309

committed

use unbuffered channels for flush

1 parent75222b3 commit62b8309Copy full SHA for 62b8309

File tree

-5

lines changed

-5

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,7 @@ func Run(t *testing.T, appHostIsPrimary bool, factory DeploymentFactory) {`
`147`	`147`	`require.NoError(t,err)`
`148`	`148`	`require.True(t,loc.Query().Has("message"))`
`149`	`149`	`require.True(t,loc.Query().Has("redirect"))`
`150`		`-assertWorkspaceLastUsedAtUpdated(t,appDetails)`
	`150`	`+assertWorkspaceLastUsedAtNotUpdated(t,appDetails)`
`151`	`151`	`})`
`152`	`152`
`153`	`153`	`t.Run("LoginWithoutAuthOnProxy",func(t*testing.T) {`
`@@ -185,7 +185,7 @@ func Run(t *testing.T, appHostIsPrimary bool, factory DeploymentFactory) {`
`185`	`185`	`// request is getting stripped.`
`186`	`186`	`require.Equal(t,u.Path,redirectURI.Path+"/")`
`187`	`187`	`require.Equal(t,u.RawQuery,redirectURI.RawQuery)`
`188`		`-assertWorkspaceLastUsedAtUpdated(t,appDetails)`
	`188`	`+assertWorkspaceLastUsedAtNotUpdated(t,appDetails)`
`189`	`189`	`})`
`190`	`190`
`191`	`191`	`t.Run("NoAccessShould404",func(t*testing.T) {`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -262,7 +262,7 @@ func TestWorkspaceApps(t *testing.T) {`
`262`	`262`	`opts.AppHost=""`
`263`	`263`	`}`
`264`	`264`
`265`		`-statsFlushCh:=make(chanchan<-struct{},1)`
	`265`	`+statsFlushCh:=make(chanchan<-struct{})`
`266`	`266`	`opts.StatsCollectorOptions.Flush=statsFlushCh`
`267`	`267`	`flushStats:=func() {`
`268`	`268`	`flushDone:=make(chanstruct{})`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -442,9 +442,9 @@ func TestWorkspaceProxyWorkspaceApps(t *testing.T) {`
`442`	`442`	`"*",`
`443`	`443`	`}`
`444`	`444`
`445`		`-proxyFlushCh:=make(chanchan<-struct{},1)`
	`445`	`+proxyFlushCh:=make(chanchan<-struct{})`
`446`	`446`	`flushStats:=func() {`
`447`		`-proxyFlushDone:=make(chanstruct{},1)`
	`447`	`+proxyFlushDone:=make(chanstruct{})`
`448`	`448`	`proxyFlushCh<-proxyFlushDone`
`449`	`449`	`<-proxyFlushDone`
`450`	`450`	`}`

Comments

(0)