Commit610740a

committed

proper release gating

1 parentbf6562a commit610740aCopy full SHA for 610740a

File tree

+11

-6

lines changed

+11

-6

lines changed

Lines changed: 11 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -194,14 +194,20 @@ func (c *Cache) prepare(ctx context.Context, db database.Store, fileID uuid.UUID`
`194`	`194`	`hitLabel="false"`
`195`	`195`
`196`	`196`	`varreleaseOnce sync.Once`
	`197`	`+release:=func() {`
	`198`	`+releaseOnce.Do(func() {`
	`199`	`+c.purge(fileID)`
	`200`	`+})`
	`201`	`+}`
`197`	`202`	`entry=&cacheEntry{`
`198`	`203`	`refCount:0,`
`199`	`204`	`value:lazy.NewWithError(func() (CacheEntryValue,error) {`
`200`	`205`	`val,err:=fetch(db,fileID)`
`201`	`206`	`iferr!=nil {`
`202`	`207`	`// Force future calls to Acquire to trigger a new fetch as soon as`
`203`	`208`	`// a fetch has failed, even if references are still held.`
`204`		`-delete(c.data,fileID)`
	`209`	`+entry.close()`
	`210`	`+release()`
`205`	`211`	`returnval,err`
`206`	`212`	`}`
`207`	`213`
`@@ -218,12 +224,11 @@ func (c *Cache) prepare(ctx context.Context, db database.Store, fileID uuid.UUID`
`218`	`224`
`219`	`225`	`entry.refCount--`
`220`	`226`	`c.currentOpenFileReferences.Dec()`
`221`		`-`
`222`		`-ifentry.refCount==0 {`
`223`		`-releaseOnce.Do(func() {`
`224`		`-c.purge(fileID)`
`225`		`-})`
	`227`	`+ifentry.refCount>0 {`
	`228`	`+return`
`226`	`229`	`}`
	`230`	`+`
	`231`	`+release()`
`227`	`232`	`},`
`228`	`233`	`}`
`229`	`234`	`c.data[fileID]=entry`

Comments

(0)