Commit5ee112b

authored

fix: Fetch all GitHub teams on login (#2951)

This wasn't looping prior, so organizations with >100 teamscouldn't login. Contributes to#2848.

1 parent59facdd commit5ee112bCopy full SHA for 5ee112b

File tree

+16

-3

lines changed

+16

-3

lines changed

Lines changed: 16 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -771,10 +771,23 @@ func configureGithubOAuth2(accessURL *url.URL, clientID, clientSecret string, al`
`771`	`771`	`returnmemberships,err`
`772`	`772`	`},`
`773`	`773`	`ListTeams:func(ctx context.Context,clienthttp.Client,orgstring) ([]github.Team,error) {`
`774`		`-teams,_,err:=github.NewClient(client).Teams.ListTeams(ctx,org,&github.ListOptions{`
	`774`	`+opt:=&github.ListOptions{`
	`775`	`+// This is the maximum amount per-page that GitHub allows.`
`775`	`776`	`PerPage:100,`
`776`		`-})`
`777`		`-returnteams,err`
	`777`	`+}`
	`778`	`+varallTeams []*github.Team`
	`779`	`+for {`
	`780`	`+teams,resp,err:=github.NewClient(client).Teams.ListTeams(ctx,org,opt)`
	`781`	`+iferr!=nil {`
	`782`	`+returnnil,err`
	`783`	`+}`
	`784`	`+allTeams=append(allTeams,teams...)`
	`785`	`+ifresp.NextPage==0 {`
	`786`	`+break`
	`787`	`+}`
	`788`	`+opt.Page=resp.NextPage`
	`789`	`+}`
	`790`	`+returnallTeams,nil`
`778`	`791`	`},`
`779`	`792`	`},nil`
`780`	`793`	`}`

Comments

(0)