Commit5bcde58

authored

fix: use matching state in status list (#18349)

It was using the latest state for all statuses, so if the last statuswas "failing" for example every status would show the failing icon.

1 parentdc5f69e commit5bcde58Copy full SHA for 5bcde58

File tree

+33

-1

lines changed

+33

-1

lines changed

Lines changed: 32 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`importtype{Meta,StoryObj}from"@storybook/react";`
	`2`	`+import{userEvent,within}from"@storybook/test";`
`2`	`3`	`importtype{WorkspaceAppStatus}from"api/typesGenerated";`
`3`	`4`	`import{`
`4`	`5`	`MockWorkspace,`
`@@ -82,6 +83,37 @@ export const SingleStatus: Story = {`
`82`	`83`	`},`
`83`	`84`	`};`
`84`	`85`
	`86`	`+exportconstMultipleStatuses:Story={`
	`87`	`+args:{`
	`88`	`+agent:mockAgent([`
	`89`	`+{`
	`90`	`+...MockWorkspaceAppStatus,`
	`91`	`+id:"status-1",`
	`92`	`+icon:"",`
	`93`	`+message:"Initial setup complete.",`
	`94`	`+created_at:createTimestamp(5,10),// 15:05:10 (after referenceDate)`
	`95`	`+uri:"",`
	`96`	`+state:"complete"asconst,`
	`97`	`+},`
	`98`	`+{`
	`99`	`+...MockWorkspaceAppStatus,`
	`100`	`+id:"status-2",`
	`101`	`+icon:"",`
	`102`	`+message:"Working...",`
	`103`	`+created_at:createTimestamp(5,0),// 15:05:00 (after referenceDate)`
	`104`	`+uri:"",`
	`105`	`+state:"working"asconst,`
	`106`	`+},`
	`107`	`+]),`
	`108`	`+},`
	`109`	`+play:async({ canvasElement})=>{`
	`110`	`+constcanvas=within(canvasElement);`
	`111`	`+constsubmitButton=canvas.getByRole("button");`
	`112`	`+awaituserEvent.click(submitButton);`
	`113`	`+awaitcanvas.findByText(/working/i);`
	`114`	`+},`
	`115`	`+};`
	`116`	`+`
`85`	`117`	`functionmockAgent(statuses:WorkspaceAppStatus[]){`
`86`	`118`	`return{`
`87`	`119`	`...MockWorkspaceAgent,`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,7 @@ export const AppStatuses: FC<AppStatusesProps> = ({`
`156`	`156`	`<divclassName="flex items-center justify-between w-full text-content-secondary">`
`157`	`157`	`<spanclassName="text-xs flex items-center gap-2">`
`158`	`158`	`<AppStatusStateIcon`
`159`		`-state={latestStatus.state}`
	`159`	`+state={status.state}`
`160`	`160`	`latest={false}`
`161`	`161`	`className="size-icon-xs w-[18px]"`
`162`	`162`	`/>`

Comments

(0)