- Notifications
You must be signed in to change notification settings - Fork1.1k
Commit5a8a19b
authored
feat: auto reconnect the terminal (#18796)
**Changes:**- Use [websocket-ts](https://www.npmjs.com/package/websocket-ts) to haveauto reconnection out of the box 🙏- Update the disconnected alert message to "Trying to connect..." sincethe connection is always trying to reconnect- Remove `useWithRetry` because it is not necessary anymore**Other topics:**- The disconnected alert is displaying a simple message, but we caninclude more info such as the number of attemtps- The reconnection feature is in a good state and adding value. IMO, anyimprovement can be done after getting this mergedClosescoder/internal#6591 parent00ba027 commit5a8a19b
File tree
8 files changed
+47
-450
lines changed- site
- src
- hooks
- pages/TerminalPage
8 files changed
+47
-450
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
120 | 120 | | |
121 | 121 | | |
122 | 122 | | |
| 123 | + | |
123 | 124 | | |
124 | 125 | | |
125 | 126 | | |
| |||
Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
This file was deleted.
0 commit comments
Comments
(0)