@@ -383,8 +383,7 @@ jobs:
383
383
touch ~/.bash_profile && echo "export BASH_SILENCE_DEPRECATION_WARNING=1" >> ~/.bash_profile
384
384
fi
385
385
export TS_DEBUG_DISCO=true
386
- gotestsum --junitfile="gotests.xml" --jsonfile="gotests.json" --rerun-fails=2 \
387
- --packages="./..." -- $PARALLEL_FLAG -short
386
+ gotestsum --junitfile="gotests.xml" --jsonfile="gotests.json" --packages="./..." -- $PARALLEL_FLAG -short
388
387
389
388
-name :Upload Test Cache
390
389
uses :./.github/actions/test-cache/upload
@@ -539,16 +538,21 @@ jobs:
539
538
# Postgres tends not to choke.
540
539
NUM_PARALLEL_PACKAGES=8
541
540
NUM_PARALLEL_TESTS=16
541
+ # Only the CLI and Agent are officially supported on Windows and the rest are too flaky
542
+ PACKAGES="./cli/...,./enterprise/cli/...,./agent/..."
542
543
elif [ "${{ runner.os }}" == "macOS" ]; then
543
544
# Our macOS runners have 8 cores. We set NUM_PARALLEL_TESTS to 16
544
545
# because the tests complete faster and Postgres doesn't choke. It seems
545
546
# that macOS's tmpfs is faster than the one on Windows.
546
547
NUM_PARALLEL_PACKAGES=8
547
548
NUM_PARALLEL_TESTS=16
549
+ # Only the CLI and Agent are officially supported on macOS and the rest are too flaky
550
+ PACKAGES="./cli/...,./enterprise/cli/...,./agent/..."
548
551
elif [ "${{ runner.os }}" == "Linux" ]; then
549
552
# Our Linux runners have 8 cores.
550
553
NUM_PARALLEL_PACKAGES=8
551
554
NUM_PARALLEL_TESTS=8
555
+ PACKAGES="./..."
552
556
fi
553
557
554
558
# by default, run tests with cache
@@ -565,10 +569,7 @@ jobs:
565
569
# invalidated. See scripts/normalize_path.sh for more details.
566
570
normalize_path_with_symlinks "$RUNNER_TEMP/sym" "$(dirname $(which terraform))"
567
571
568
- # We rerun failing tests to counteract flakiness coming from Postgres
569
- # choking on macOS and Windows sometimes.
570
- DB=ci gotestsum --rerun-fails=2 --rerun-fails-max-failures=50 \
571
- --format standard-quiet --packages "./..." \
572
+ DB=ci gotestsum --format standard-quiet --packages "$PACKAGES" \
572
573
-- -timeout=20m -v -p $NUM_PARALLEL_PACKAGES -parallel=$NUM_PARALLEL_TESTS $TESTCOUNT
573
574
574
575
-name :Upload Go Build Cache
@@ -638,7 +639,6 @@ jobs:
638
639
env :
639
640
POSTGRES_VERSION :" 17"
640
641
TS_DEBUG_DISCO :" true"
641
- TEST_RETRIES :2
642
642
run :|
643
643
make test-postgres
644
644
@@ -689,7 +689,7 @@ jobs:
689
689
# c.f. discussion on https://github.com/coder/coder/pull/15106
690
690
-name :Run Tests
691
691
run :|
692
- gotestsum --junitfile="gotests.xml" --packages="./..." --rerun-fails=2 --rerun-fails-abort-on-data-race -- -race -parallel 4 -p 4
692
+ gotestsum --junitfile="gotests.xml" --packages="./..." -- -race -parallel 4 -p 4
693
693
694
694
-name :Upload Test Cache
695
695
uses :./.github/actions/test-cache/upload
@@ -741,7 +741,7 @@ jobs:
741
741
POSTGRES_VERSION :" 17"
742
742
run :|
743
743
make test-postgres-docker
744
- DB=ci gotestsum --junitfile="gotests.xml" --packages="./..." --rerun-fails=2 --rerun-fails-abort-on-data-race -- -race -parallel 4 -p 4
744
+ DB=ci gotestsum --junitfile="gotests.xml" --packages="./..." -- -race -parallel 4 -p 4
745
745
746
746
-name :Upload Test Cache
747
747
uses :./.github/actions/test-cache/upload
@@ -863,7 +863,6 @@ jobs:
863
863
if :${{ !matrix.variant.premium }}
864
864
env :
865
865
DEBUG :pw:api
866
- CODER_E2E_TEST_RETRIES :2
867
866
working-directory :site
868
867
869
868
# Run all of the tests with a premium license
@@ -873,7 +872,6 @@ jobs:
873
872
DEBUG :pw:api
874
873
CODER_E2E_LICENSE :${{ secrets.CODER_E2E_LICENSE }}
875
874
CODER_E2E_REQUIRE_PREMIUM_TESTS :" 1"
876
- CODER_E2E_TEST_RETRIES :2
877
875
working-directory :site
878
876
879
877
-name :Upload Playwright Failed Tests