Commit574e5d3

authored

fix: Remove case sensitivity check in OIDC email domain (#4534)

1 parent0d0ea98 commit574e5d3Copy full SHA for 574e5d3

File tree

+10

-1

lines changed

+10

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -261,7 +261,7 @@ func (api API) userOIDC(rw http.ResponseWriter, r http.Request) {`
`261`	`261`	`username=httpapi.UsernameFrom(username)`
`262`	`262`	`}`
`263`	`263`	`ifapi.OIDCConfig.EmailDomain!="" {`
`264`		`-if!strings.HasSuffix(email,api.OIDCConfig.EmailDomain) {`
	`264`	`+if!strings.HasSuffix(strings.ToLower(email),strings.ToLower(api.OIDCConfig.EmailDomain)) {`
`265`	`265`	`httpapi.Write(ctx,rw,http.StatusForbidden, codersdk.Response{`
`266`	`266`	`Message:fmt.Sprintf("Your email %q is not a part of the %q domain!",email,api.OIDCConfig.EmailDomain),`
`267`	`267`	`})`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -373,6 +373,15 @@ func TestUserOIDC(t *testing.T) {`
`373`	`373`	`AllowSignups:true,`
`374`	`374`	`EmailDomain:"coder.com",`
`375`	`375`	`StatusCode:http.StatusForbidden,`
	`376`	`+}, {`
	`377`	`+Name:"EmailDomainCaseInsensitive",`
	`378`	`+Claims: jwt.MapClaims{`
	`379`	`+"email":"kyle@KWC.io",`
	`380`	`+"email_verified":true,`
	`381`	`+},`
	`382`	`+AllowSignups:true,`
	`383`	`+EmailDomain:"kwc.io",`
	`384`	`+StatusCode:http.StatusTemporaryRedirect,`
`376`	`385`	`}, {`
`377`	`386`	`Name:"EmptyClaims",`
`378`	`387`	`Claims: jwt.MapClaims{},`

Comments

(0)