Commit5603be8

committed

PR feedback

1 parent822b677 commit5603be8Copy full SHA for 5603be8

File tree

-2

lines changed

-2

lines changed

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -383,6 +383,9 @@ func OAuth2ProviderApp(accessURL *url.URL, dbApp database.OAuth2ProviderApp) cod`
`383`	`383`	`}).String(),`
`384`	`384`	`// We do not currently support DeviceAuth.`
`385`	`385`	`DeviceAuth:"",`
	`386`	`+TokenRevoke:accessURL.ResolveReference(&url.URL{`
	`387`	`+Path:"/oauth2/revoke",`
	`388`	`+}).String(),`
`386`	`389`	`},`
`387`	`390`	`}`
`388`	`391`	`}`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -161,7 +161,6 @@ func revokeAPIKeyInTx(ctx context.Context, db database.Store, token string, appI`
`161`	`161`	`iferr!=nil {`
`162`	`162`	`iferrors.Is(err,sql.ErrNoRows) {`
`163`	`163`	`// API key not found - return success per RFC 7009 (don't reveal token existence)`
`164`		`-// Note: This covers both non-existent keys and invalid key ID formats`
`165`	`164`	`returnnil`
`166`	`165`	`}`
`167`	`166`	`returnxerrors.Errorf("get api key by id: %w",err)`
`@@ -175,7 +174,7 @@ func revokeAPIKeyInTx(ctx context.Context, db database.Store, token string, appI`
`175`	`174`
`176`	`175`	`// Verify the API key was created by OAuth2`
`177`	`176`	`ifapiKey.LoginType!=database.LoginTypeOAuth2ProviderApp {`
`178`		`-returnxerrors.New("API key is not anOAuth2 token")`
	`177`	`+returnxerrors.New("api key is not anoauth2 token")`
`179`	`178`	`}`
`180`	`179`
`181`	`180`	`// Find the associated OAuth2 token to verify ownership`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,7 @@ type OAuth2ProviderApp struct {`
`27`	`27`	`typeOAuth2AppEndpointsstruct {`
`28`	`28`	Authorizationstring`json:"authorization"`
`29`	`29`	Tokenstring`json:"token"`
	`30`	+TokenRevokestring`json:"token_revoke"`
`30`	`31`	`// DeviceAuth is optional.`
`31`	`32`	DeviceAuthstring`json:"device_authorization"`
`32`	`33`	`}`

Comments

(0)