Commit5241805

committed

fix!: enforce agent names be case-insensitive-unique per-workspace

1 parent2a248b1 commit5241805Copy full SHA for 5241805

File tree

-2

lines changed

-2

lines changed

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -215,10 +215,12 @@ func ConvertState(ctx context.Context, modules []*tfjson.StateModule, rawGraph s`
`215`	`215`	`returnnil,xerrors.Errorf("decode agent attributes: %w",err)`
`216`	`216`	`}`
`217`	`217`
`218`		`-if_,ok:=agentNames[tfResource.Name];ok {`
	`218`	`+// Agent names must be case-insensitive-unique, to be unambiguous in`
	`219`	+// `coder_app`s and CoderVPN DNS names.
	`220`	`+if_,ok:=agentNames[strings.ToLower(tfResource.Name)];ok {`
`219`	`221`	`returnnil,xerrors.Errorf("duplicate agent name: %s",tfResource.Name)`
`220`	`222`	`}`
`221`		`-agentNames[tfResource.Name]=struct{}{}`
	`223`	`+agentNames[strings.ToLower(tfResource.Name)]=struct{}{}`
`222`	`224`
`223`	`225`	`// Handling for deprecated attributes. login_before_ready was replaced`
`224`	`226`	`// by startup_script_behavior, but we still need to support it for`

Comments

(0)