Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit516fb44

Browse files
authored
feat: display required badge instead of diagnostic text when extra code = required (#18006)
The tooltip hover uses the summary text from the diagnostic<img width="562" alt="Screenshot 2025-05-23 at 12 51 51"src="https://github.com/user-attachments/assets/2246abc7-dc1c-4dc2-8303-bee62d152e21"/>
1 parent30a910b commit516fb44

File tree

2 files changed

+45
-18
lines changed

2 files changed

+45
-18
lines changed

‎site/src/index.css

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,4 +107,9 @@
107107
--removed-body-scroll-bar-size:0!important;
108108
margin-right:0!important;
109109
}
110+
111+
/* Prevent layout shift when modals open by maintaining scrollbar width */
112+
html {
113+
scrollbar-gutter: stable;
114+
}
110115
}

‎site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx

Lines changed: 40 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,7 @@ export const DynamicParameter: FC<DynamicParameterProps> = ({
8989
/>
9090
)}
9191
</div>
92-
{parameter.diagnostics.length>0&&(
93-
<ParameterDiagnosticsdiagnostics={parameter.diagnostics}/>
94-
)}
92+
<ParameterDiagnosticsdiagnostics={parameter.diagnostics}/>
9593
</div>
9694
);
9795
};
@@ -112,6 +110,9 @@ const ParameterLabel: FC<ParameterLabelProps> = ({
112110
constdisplayName=parameter.display_name
113111
?parameter.display_name
114112
:parameter.name;
113+
consthasRequiredDiagnostic=parameter.diagnostics?.find(
114+
(d)=>d.extra?.code==="required",
115+
);
115116

116117
return(
117118
<divclassName="flex items-start gap-2">
@@ -186,6 +187,22 @@ const ParameterLabel: FC<ParameterLabelProps> = ({
186187
</Tooltip>
187188
</TooltipProvider>
188189
)}
190+
{hasRequiredDiagnostic&&(
191+
<TooltipProviderdelayDuration={100}>
192+
<Tooltip>
193+
<TooltipTriggerasChild>
194+
<spanclassName="flex items-center">
195+
<Badgesize="sm"variant="destructive"border="none">
196+
Required
197+
</Badge>
198+
</span>
199+
</TooltipTrigger>
200+
<TooltipContentclassName="max-w-xs">
201+
{hasRequiredDiagnostic.summary||"Required parameter"}
202+
</TooltipContent>
203+
</Tooltip>
204+
</TooltipProvider>
205+
)}
189206
</Label>
190207

191208
{Boolean(parameter.description)&&(
@@ -558,21 +575,26 @@ const ParameterDiagnostics: FC<ParameterDiagnosticsProps> = ({
558575
diagnostics,
559576
})=>{
560577
return(
561-
<divclassName="flex flex-col gap-2">
562-
{diagnostics.map((diagnostic,index)=>(
563-
<div
564-
key={`parameter-diagnostic-${diagnostic.summary}-${index}`}
565-
className={`text-xs px-1${
566-
diagnostic.severity==="error"
567-
?"text-content-destructive"
568-
:"text-content-warning"
569-
}`}
570-
>
571-
<pclassName="font-medium">{diagnostic.summary}</p>
572-
{diagnostic.detail&&<pclassName="m-0">{diagnostic.detail}</p>}
573-
</div>
574-
))}
575-
</div>
578+
<>
579+
{diagnostics.map((diagnostic,index)=>{
580+
if(diagnostic.extra?.code==="required"){
581+
returnnull;
582+
}
583+
return(
584+
<div
585+
key={`parameter-diagnostic-${diagnostic.summary}-${index}`}
586+
className={`text-xs px-1${
587+
diagnostic.severity==="error"
588+
?"text-content-destructive"
589+
:"text-content-warning"
590+
}`}
591+
>
592+
<pclassName="font-medium">{diagnostic.summary}</p>
593+
{diagnostic.detail&&<pclassName="m-0">{diagnostic.detail}</p>}
594+
</div>
595+
);
596+
})}
597+
</>
576598
);
577599
};
578600

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp