Commit512fdbf

authored

chore: debounce agent watch-metadata stream (#6940)

1 parente40b077 commit512fdbfCopy full SHA for 512fdbf

File tree

+15

-1

lines changed

+15

-1

lines changed

Lines changed: 12 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,7 @@ import (`
`6`	`6`	`"database/sql"`
`7`	`7`	`"encoding/json"`
`8`	`8`	`"errors"`
	`9`	`+"flag"`
`9`	`10`	`"fmt"`
`10`	`11`	`"net"`
`11`	`12`	`"net/http"`
`@@ -18,6 +19,7 @@ import (`
`18`	`19`	`"sync/atomic"`
`19`	`20`	`"time"`
`20`	`21`
	`22`	`+"github.com/bep/debounce"`
`21`	`23`	`"github.com/go-chi/chi/v5"`
`22`	`24`	`"github.com/google/uuid"`
`23`	`25`	`"go.opentelemetry.io/otel/trace"`
`@@ -1484,9 +1486,18 @@ func (api API) watchWorkspaceAgentMetadata(rw http.ResponseWriter, r http.Requ`
`1484`	`1486`	`// Send initial metadata.`
`1485`	`1487`	`sendMetadata(true)`
`1486`	`1488`
	`1489`	`+// We debounce metadata updates to avoid overloading the frontend when`
	`1490`	`+// an agent is sending a lot of updates.`
	`1491`	`+pubsubDebounce:=debounce.New(time.Second)`
	`1492`	`+ifflag.Lookup("test.v")!=nil {`
	`1493`	`+pubsubDebounce=debounce.New(time.Millisecond*100)`
	`1494`	`+}`
	`1495`	`+`
`1487`	`1496`	`// Send metadata on updates.`
`1488`	`1497`	`cancelSub,err:=api.Pubsub.Subscribe(watchWorkspaceAgentMetadataChannel(workspaceAgent.ID),func(_ context.Context,_ []byte) {`
`1489`		`-sendMetadata(true)`
	`1498`	`+pubsubDebounce(func() {`
	`1499`	`+sendMetadata(true)`
	`1500`	`+})`
`1490`	`1501`	`})`
`1491`	`1502`	`iferr!=nil {`
`1492`	`1503`	`httpapi.InternalServerError(rw,err)`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -173,6 +173,7 @@ require (`
`173`	`173`
`174`	`174`	`require (`
`175`	`175`	`cloud.google.com/go/loggingv1.6.1// indirect`
	`176`	`+github.com/bep/debouncev1.2.1// indirect`
`176`	`177`	`github.com/dgraph-io/badger/v3v3.2103.5// indirect`
`177`	`178`	`github.com/dustin/go-humanizev1.0.1// indirect`
`178`	`179`	`github.com/golang/glogv1.0.0// indirect`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -270,6 +270,8 @@ github.com/beorn7/perks v0.0.0-20180321164747-3a771d992973/go.mod h1:Dwedo/Wpr24`
`270`	`270`	`github.com/beorn7/perksv1.0.0/go.mod h1:KWe93zE9D1o94FZ5RNwFwVgaQK1VOXiVxmqh+CedLV8=`
`271`	`271`	`github.com/beorn7/perksv1.0.1 h1:VlbKKnNfV8bJzeqoa4cOKqO6bYr3WgKZxO8Z16+hsOM=`
`272`	`272`	`github.com/beorn7/perksv1.0.1/go.mod h1:G2ZrVWU2WbWT9wwq4/hrbKbnv/1ERSJQ0ibhJ6rlkpw=`
	`273`	`+github.com/bep/debouncev1.2.1 h1:v67fRdBA9UQu2NhLFXrSg0Brw7CexQekrBwDMM8bzeY=`
	`274`	`+github.com/bep/debouncev1.2.1/go.mod h1:H8yggRPQKLUhUoqrJC1bO2xNya7vanpDl7xR3ISbCJ0=`
`273`	`275`	`github.com/bep/godartsassv0.16.0 h1:nTpenrZBQjVSjLkCw3AgnYmBB2czauTJa4BLLv448qg=`
`274`	`276`	`github.com/bep/godartsassv0.16.0/go.mod h1:6LvK9RftsXMxGfsA0LDV12AGc4Jylnu6NgHL+Q5/pE8=`
`275`	`277`	`github.com/bep/golibsassv1.1.0 h1:pjtXr00IJZZaOdfryNa9wARTB3Q0BmxC3/V1KNcgyTw=`

Comments

(0)