NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

Commit50f2fca

authored

chore: Add comment explaining why testpackage is enabled (#774)

A discussion (linked below) was had that touched on why this linteris enabled. To avoid losing that history, adding the comment inline withour linting rules can avoid duplicating this discussion!#741 (comment)

1 parent0d53795 commit50f2fcaCopy full SHA for 50f2fca

File tree

1 file changed

-0

lines changed

.golangci.yml

1 file changed

-0

lines changed

`‎.golangci.yml`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -251,6 +251,13 @@ linters:`
`251`	`251`	`-staticcheck`
`252`	`252`	`-structcheck`
`253`	`253`	`-tenv`
	`254`	`+# In Go, it's possible for a package to test it's internal functionality`
	`255`	`+# without testing any exported functions. This is enabled to promote`
	`256`	`+# decomposing a package before testing it's internals. A function caller`
	`257`	`+# should be able to test most of the functionality from exported functions.`
	`258`	`+#`
	`259`	`+# There are edge-cases to this rule, but they should be carefully considered`
	`260`	`+# to avoid structural inconsistency.`
`254`	`261`	`-testpackage`
`255`	`262`	`-tparallel`
`256`	`263`	`-typecheck`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit50f2fca

File tree

1 file changed

1 file changed

`‎.golangci.yml`

0 commit comments