NotificationsYou must be signed in to change notification settings
Fork1.1k
Star11.7k

Commit5033ee8

committed

add unit test for site wide custom role deletE

1 parent817bb4b commit5033ee8Copy full SHA for 5033ee8

File tree

2 files changed

+14

-2

lines changed

coderd/database/dbauthz
- dbauthz.go
- dbauthz_test.go

2 files changed

+14

-2

lines changed

`‎coderd/database/dbauthz/dbauthz.go‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -964,7 +964,7 @@ func (q *querier) DeleteCustomRole(ctx context.Context, arg database.DeleteCusto`
`964`	`964`	`returnerr`
`965`	`965`	`}`
`966`	`966`	`}else {`
`967`		`-iferr:=q.authorizeContext(ctx,policy.ActionCreate,rbac.ResourceAssignRole);err!=nil {`
	`967`	`+iferr:=q.authorizeContext(ctx,policy.ActionDelete,rbac.ResourceAssignRole);err!=nil {`
`968`	`968`	`returnerr`
`969`	`969`	`}`
`970`	`970`	`}`

`‎coderd/database/dbauthz/dbauthz_test.go‎`

Lines changed: 13 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1247,7 +1247,7 @@ func (s *MethodTestSuite) TestUser() {`
`1247`	`1247`	`s.Run("CustomRoles",s.Subtest(func(db database.Store,check*expects) {`
`1248`	`1248`	`check.Args(database.CustomRolesParams{}).Asserts(rbac.ResourceAssignRole,policy.ActionRead).Returns([]database.CustomRole{})`
`1249`	`1249`	`}))`
`1250`		`-s.Run("DeleteCustomRole",s.Subtest(func(db database.Store,check*expects) {`
	`1250`	`+s.Run("Organization/DeleteCustomRole",s.Subtest(func(db database.Store,check*expects) {`
`1251`	`1251`	`customRole:=dbgen.CustomRole(s.T(),db, database.CustomRole{`
`1252`	`1252`	`OrganizationID: uuid.NullUUID{`
`1253`	`1253`	`UUID:uuid.New(),`
`@@ -1260,6 +1260,18 @@ func (s *MethodTestSuite) TestUser() {`
`1260`	`1260`	`}).Asserts(`
`1261`	`1261`	`rbac.ResourceAssignOrgRole.InOrg(customRole.OrganizationID.UUID),policy.ActionDelete)`
`1262`	`1262`	`}))`
	`1263`	`+s.Run("Site/DeleteCustomRole",s.Subtest(func(db database.Store,check*expects) {`
	`1264`	`+customRole:=dbgen.CustomRole(s.T(),db, database.CustomRole{`
	`1265`	`+OrganizationID: uuid.NullUUID{`
	`1266`	`+UUID:uuid.Nil,`
	`1267`	`+Valid:false,`
	`1268`	`+},`
	`1269`	`+})`
	`1270`	`+check.Args(database.DeleteCustomRoleParams{`
	`1271`	`+Name:customRole.Name,`
	`1272`	`+}).Asserts(`
	`1273`	`+rbac.ResourceAssignRole,policy.ActionDelete)`
	`1274`	`+}))`
`1263`	`1275`	`s.Run("Blank/UpsertCustomRole",s.Subtest(func(db database.Store,check*expects) {`
`1264`	`1276`	`// Blank is no perms in the role`
`1265`	`1277`	`check.Args(database.UpsertCustomRoleParams{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5033ee8

File tree

2 files changed

2 files changed

`‎coderd/database/dbauthz/dbauthz.go‎`

`‎coderd/database/dbauthz/dbauthz_test.go‎`

0 commit comments